linux-kernel - Re: [PATCH v1 0/5] gpio: regmap: Make use of 'ngpios' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7crrgl2iFn34gck@smile.fi.intel.com>
Date: Thu, 20 Feb 2025 15:18:38 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	Michael Walle <mwalle@...nel.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	athieu Dubois-Briand <mathieu.dubois-briand@...tlin.com>
Subject: Re: [PATCH v1 0/5] gpio: regmap: Make use of 'ngpios' property

On Fri, Feb 14, 2025 at 11:50:53AM +0100, Linus Walleij wrote:
> On Thu, Feb 13, 2025 at 8:56 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> 
> > It appears that regmap GPIO doesn't take into account 'ngpios' property
> > and requires hard coded values or duplication of the parsing the same
> > outside of GPIO library. This miniseries addresses that.
> >
> > For the record, I have checked all bgpio_init() users and haven't seen
> > the suspicious code that this series might break, e.g., an equivalent of
> > something like this:
> >
> > static int foo_probe(struct device *dev)
> > {
> >         struct gpio_chip *gc = devm_kzalloc(...);
> >         struct fwnode_handle *fwnode = ...; // NOT dev_fwnode(dev)!
> >
> >         ...
> >         gc->parent = dev;
> >         gc->fwnode = fwnode;
> >
> >         ret = bgpio_init(gc, dev, ...);
> >         ...
> > }
> >
> > Reported-by: Mathieu Dubois-Briand <mathieu.dubois-briand@...tlin.com>
> 
> Thanks for fixing this Andy!
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Thank you for the review!

Bart, do you think it can be applied?

-- 
With Best Regards,
Andy Shevchenko