linux-kernel - Re: [PATCH] mei: Add error logging in IRQ handler to prevent silent failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025022023-childlike-superjet-f096@gregkh>
Date: Thu, 20 Feb 2025 15:16:03 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Wentao Liang <vulab@...as.ac.cn>
Cc: alexander.usyskin@...el.com, arnd@...db.de,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] mei: Add error logging in IRQ handler to prevent silent
 failures

On Thu, Feb 20, 2025 at 09:34:35PM +0800, Wentao Liang wrote:
> Log mei_irq_write_handler() errors to prevent silent IRQ handling failures.
> 
> Fixes: 962ff7bcec24 ("mei: replace callback structures used as list head by list_head")
> Cc: stable@...r.kernel.org # 4.11+
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
> ---
>  drivers/misc/mei/hw-me.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/misc/mei/hw-me.c b/drivers/misc/mei/hw-me.c
> index d11a0740b47c..5df42a64b4db 100644
> --- a/drivers/misc/mei/hw-me.c
> +++ b/drivers/misc/mei/hw-me.c
> @@ -1415,6 +1415,8 @@ irqreturn_t mei_me_irq_thread_handler(int irq, void *dev_id)
>  	if (dev->pg_event != MEI_PG_EVENT_WAIT &&
>  	    dev->pg_event != MEI_PG_EVENT_RECEIVED) {
>  		rets = mei_irq_write_handler(dev, &cmpl_list);
> +		if (rets)
> +			dev_err(dev->dev, "mei_irq_write_handler ret = %d.\n", rets);
>  		dev->hbuf_is_ready = mei_hbuf_is_ready(dev);
>  	}
>  
> -- 
> 2.42.0.windows.2
> 

How was this found and tested?

And why print an error message in an irq handler, isn't that going to be
messy?  What can the user do with this message?

thanks,

greg k-h