linux-kernel - Re: [PATCH v4 2/5] nvmem: core: verify cell's raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7c5niuwR3TVTQrj@finisterre.sirena.org.uk>
Date: Thu, 20 Feb 2025 14:18:06 +0000
From: Mark Brown <broonie@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Akhil P Oommen <quic_akhilpo@...cinc.com>,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/5] nvmem: core: verify cell's raw_len

On Wed, Feb 19, 2025 at 05:14:43PM +0200, Dmitry Baryshkov wrote:
> On Wed, 19 Feb 2025 at 16:51, Mark Brown <broonie@...nel.org> wrote:
> > On Thu, Jan 09, 2025 at 06:35:46AM +0200, Dmitry Baryshkov wrote:

> > > Check that the NVMEM cell's raw_len is a aligned to word_size. Otherwise
> > > Otherwise drivers might face incomplete read while accessing the last
> > > part of the NVMEM cell.

> > I'm seeing a bunch of failures on i.MX platforms in -next which bisect
> > to this patch.  For example on the i.MX6q based UDOOq various things
> > including the ethernet fail to come up due to the efuse not appearing:

> > [    1.735264] nvmem imx-ocotp0: cell mac-addr raw len 6 unaligned to nvmem word size 4
> > [    1.735289] imx_ocotp 21bc000.efuse: probe with driver imx_ocotp failed with error -22

> This looks like an error on the i.MX platforms. The raw_len must be
> aligned to word size. I think the easiest fix is to implement the
> .fixup_dt_cell_info() callback like I did for the qfprom driver.

That sounds pluasible, but as things stand we've got a regression on
these platforms - taking out ethernet breaks NFS boot apart from
anything else.  I'd also be a bit concerned that there might be other
users with issues, does this need an audit of users before trying to
enforce this requirement?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)