linux-kernel - Re: [PATCH] i2c: core: mark i2c_detect_address noinline_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVdKvB1UWc0-opEoAwoOejcwmrFJtSB5EUqVqZD7-vP8A@mail.gmail.com>
Date: Thu, 20 Feb 2025 16:16:11 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Su Hui <suhui@...china.com>
Cc: wsa+renesas@...g-engineering.com, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] i2c: core: mark i2c_detect_address noinline_for_stack

Hi Sui,

On Mon, 10 Feb 2025 at 09:03, Su Hui <suhui@...china.com> wrote:
> When compile with CONFIG_FRAME_WARN=1024, there can be a warning:
>
> drivers/i2c/i2c-core-base.c: In function ‘i2c_detect.isra’:
> drivers/i2c/i2c-core-base.c:2507:1: warning: the frame size of 1028 bytes
> is larger than 1024 bytes [-Wframe-larger-than=].
>  2507 | }
>       | ^
>
> Mark i2c_detect_address() noinline_for_stack to avoid this warning.
>
> Signed-off-by: Su Hui <suhui@...china.com>

I have posted an alternative fix:
"[PATCH] i2c: core: Allocate temporary client dynamically"
https://lore.kernel.org/f9aa39362e918b62aec0567f899b37d8d3c44710.1740064176.git.geert+renesas@glider.be/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds