linux-kernel - Re: Null-pointer-dereference in ef100_process_design

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <92115b07-a0ba-1881-cbca-3798510c3f16@gmail.com>
Date: Thu, 20 Feb 2025 15:35:50 +0000
From: Edward Cree <ecree.xilinx@...il.com>
To: Kyungwook Boo <bookyungwook@...il.com>,
 Martin Habets <habetsm.xilinx@...il.com>
Cc: netdev@...r.kernel.org, linux-net-drivers@....com,
 linux-kernel@...r.kernel.org
Subject: Re: Null-pointer-dereference in ef100_process_design_param()

On 19/02/2025 10:04, Kyungwook Boo wrote:
> It seems that a null pointer dereference issue in ef100_process_design_param()
> can occur due to an uninitialized pointer efx->net_dev.

Yes, your diagnosis looks correct to me.
Moreover, besides the calls you identify, the function also has calls to
 netif_err() using the same efx->net_dev pointer.

My preferred solution is to keep ef100_check_design_params() where it is,
 but move the netif_set_tso_max_{size,segs}() calls into
 ef100_probe_netdev(), after the netdevice is allocated, and using the
 values stashed in nic_data; also to replace the netif_err() calls with
 pci_err().  I will develop a patch accordingly.