linux-kernel - Re: [PATCH] leds: st1202: Fix an error handling path in st1202

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250220155834.GA824852@google.com>
Date: Thu, 20 Feb 2025 15:58:34 +0000
From: Lee Jones <lee@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Pavel Machek <pavel@...nel.org>,
	Vicentiu Galanopulo <vicentiu.galanopulo@...ote-tech.co.uk>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-leds@...r.kernel.org
Subject: Re: [PATCH] leds: st1202: Fix an error handling path in
 st1202_probe()

On Wed, 19 Feb 2025, Christophe JAILLET wrote:

> devm_mutex_init() may return -ENOMEM.
> So this error should be handled in st1202_probe().

The start of a new sentence shouldn't warrant a line break.

> Fixes: 259230378c65 ("leds: Add LED1202 I2C driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/leds/leds-st1202.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c
> index b691c4886993..4fc17d518292 100644
> --- a/drivers/leds/leds-st1202.c
> +++ b/drivers/leds/leds-st1202.c
> @@ -356,7 +356,10 @@ static int st1202_probe(struct i2c_client *client)
>  	if (!chip)
>  		return -ENOMEM;
>  
> -	devm_mutex_init(&client->dev, &chip->lock);
> +	ret = devm_mutex_init(&client->dev, &chip->lock);
> +	if (ret < 0)

My assumption is that anything but 0 would be bad, thus:

	if (ret)

> +		return ret;
> +
>  	chip->client = client;
>  
>  	ret = st1202_dt_init(chip);
> -- 
> 2.48.1
> 

-- 
Lee Jones [李琼斯]