linux-kernel - Re: [PATCH] riscv: dts: allwinner: d1: Add thermal sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4835098.rnE6jSC6OK@jernej-laptop>
Date: Thu, 20 Feb 2025 17:05:19 +0100
From: Jernej Škrabec <jernej.skrabec@...il.com>
To: Maxim Kiselev <bigunclemax@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Chen-Yu Tsai <wens@...e.org>, Samuel Holland <samuel@...lland.org>,
 Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 John Watts <contact@...kia.org>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-sunxi@...ts.linux.dev, linux-riscv@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Andre Przywara <andre.przywara@....com>,
 John Watts <contact@...kia.org>
Subject: Re: [PATCH] riscv: dts: allwinner: d1: Add thermal sensor

Dne četrtek, 20. februar 2025 ob 10:25:10 Srednjeevropski standardni čas je John Watts napisal(a):
> From: Maxim Kiselev <bigunclemax@...il.com>
> 
> This patch adds a thermal sensor controller node for the D1/T113s.
> Also it adds a THS calibration data cell to efuse node.
> 
> Signed-off-by: Maxim Kiselev <bigunclemax@...il.com>
> Reviewed-by: Andre Przywara <andre.przywara@....com>
> Signed-off-by: John Watts <contact@...kia.org>
> [John Watts: Remove disabled status]

I prefer other patch, which was posted not too long ago since it also has
thermal zones.

Best regards,
Jernej

> ---
> This is a quick fixed version of Maxim Kiselev's patch from here:
> 
> https://lore.kernel.org/all/20231217210629.131486-4-bigunclemax@gmail.com/
> 
> It removes the disabled status as requested. I've tested it by adding thermal
> zones to my board and it works from what I can see.
> ---
>  arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi b/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi
> index e4175adb028da2be539e7aa316206fec4810adfc..cc3f9cc9b8ed20121924cc932412a6b6342a2f86 100644
> --- a/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi
> +++ b/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi
> @@ -166,6 +166,18 @@ gpadc: adc@...9000 {
>  			#io-channel-cells = <1>;
>  		};
>  
> +		ths: thermal-sensor@...9400 {
> +			compatible = "allwinner,sun20i-d1-ths";
> +			reg = <0x02009400 0x400>;
> +			interrupts = <SOC_PERIPHERAL_IRQ(58) IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&ccu CLK_BUS_THS>;
> +			clock-names = "bus";
> +			resets = <&ccu RST_BUS_THS>;
> +			nvmem-cells = <&ths_calibration>;
> +			nvmem-cell-names = "calibration";
> +			#thermal-sensor-cells = <0>;
> +		};
> +
>  		dmic: dmic@...1000 {
>  			compatible = "allwinner,sun20i-d1-dmic",
>  				     "allwinner,sun50i-h6-dmic";
> @@ -426,6 +438,10 @@ sid: efuse@...6000 {
>  			reg = <0x3006000 0x1000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> +
> +			ths_calibration: thermal-sensor-calibration@14 {
> +				reg = <0x14 0x4>;
> +			};
>  		};
>  
>  		crypto: crypto@...0000 {
> 
> ---
> base-commit: eca631b8fe808748d7585059c4307005ca5c5820
> change-id: 20250220-thermal-803de9da0ce6
> 
> Best regards,
>