linux-kernel - Re: [PATCH] PCI: endpoint: Fix a double free in __pci_epc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250220162313.GD2510987@rocinante>
Date: Fri, 21 Feb 2025 01:23:13 +0900
From: Krzysztof Wilczyński <kw@...ux.com>
To: Ma Ke <make24@...as.ac.cn>
Cc: lpieralisi@...nel.org, mani@...nel.org, kishon@...nel.org,
	bhelgaas@...gle.com, jpinto@...opsys.com, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] PCI: endpoint: Fix a double free in __pci_epc_create()

Hello,

> > The put_device(&epc->dev) call will trigger pci_epc_release() which
> > frees "epc" so the kfree(epc) on the next line is a double free.
> > 
> > Found by code review.

[...]
> Which kernel release did you review?  I don't see this kfree() when looking
> at the current code base per:
> 
>   https://elixir.bootlin.com/linux/v6.13-rc1/source/drivers/pci/endpoint/pci-epc-core.c#L956-L1020

I will answer my own question.  This surplus kfree() has already been
removed as part of the following commit:

  c9501d268944 ("PCI: endpoint: Fix double free in __pci_epc_create()")

Nevertheless, thank you for the patch.

	Krzysztof