linux-kernel - Re: [PATCH v6 4/8] crypto: ccp: Fix uapi definitions of PSP errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d72dbe54-2d50-9859-7004-03daf419be86@amd.com>
Date: Thu, 20 Feb 2025 10:34:51 -0600
From: Tom Lendacky <thomas.lendacky@....com>
To: Dionna Glaze <dionnaglaze@...gle.com>, linux-kernel@...r.kernel.org,
 x86@...nel.org, "Borislav Petkov (AMD)" <bp@...en8.de>,
 Herbert Xu <herbert@...dor.apana.org.au>, linux-crypto@...r.kernel.org
Cc: linux-coco@...ts.linux.dev, Alexey Kardashevskiy <aik@....com>,
 Sean Christopherson <seanjc@...gle.com>, Paolo Bonzini
 <pbonzini@...hat.com>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Dave Hansen <dave.hansen@...ux.intel.com>,
 John Allen <john.allen@....com>, "David S. Miller" <davem@...emloft.net>,
 Luis Chamberlain <mcgrof@...nel.org>, Russ Weight <russ.weight@...ux.dev>,
 Danilo Krummrich <dakr@...hat.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Tianfei zhang <tianfei.zhang@...el.com>, stable@...r.kernel.org,
 Ashish Kalra <ashish.kalra@....com>, Michael Roth <michael.roth@....com>
Subject: Re: [PATCH v6 4/8] crypto: ccp: Fix uapi definitions of PSP errors

On 11/13/24 10:24, Tom Lendacky wrote:
> On 11/12/24 17:22, Dionna Glaze wrote:
>> From: Alexey Kardashevskiy <aik@....com>
>>
>> Additions to the error enum after the explicit 0x27 setting for
>> SEV_RET_INVALID_KEY leads to incorrect value assignments.
>>
>> Use explicit values to match the manufacturer specifications more
>> clearly.
>>
>> Fixes: 3a45dc2b419e ("crypto: ccp: Define the SEV-SNP commands")
>>
>> CC: Sean Christopherson <seanjc@...gle.com>
>> CC: Paolo Bonzini <pbonzini@...hat.com>
>> CC: Thomas Gleixner <tglx@...utronix.de>
>> CC: Ingo Molnar <mingo@...hat.com>
>> CC: Borislav Petkov <bp@...en8.de>
>> CC: Dave Hansen <dave.hansen@...ux.intel.com>
>> CC: Ashish Kalra <ashish.kalra@....com>
>> CC: Tom Lendacky <thomas.lendacky@....com>
>> CC: John Allen <john.allen@....com>
>> CC: Herbert Xu <herbert@...dor.apana.org.au>
>> CC: "David S. Miller" <davem@...emloft.net>
>> CC: Michael Roth <michael.roth@....com>
>> CC: Luis Chamberlain <mcgrof@...nel.org>
>> CC: Russ Weight <russ.weight@...ux.dev>
>> CC: Danilo Krummrich <dakr@...hat.com>
>> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> CC: "Rafael J. Wysocki" <rafael@...nel.org>
>> CC: Tianfei zhang <tianfei.zhang@...el.com>
>> CC: Alexey Kardashevskiy <aik@....com>
>> CC: stable@...r.kernel.org
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@....com>
>> Signed-off-by: Dionna Glaze <dionnaglaze@...gle.com>
> 
> Reviewed-by: Tom Lendacky <thomas.lendacky@....com>

@Boris or @Herbert, can we pick up this fix separate from this series?
It can probably go through either the tip tree or crypto tree.

Thanks,
Tom

> 
>> ---
>>  include/uapi/linux/psp-sev.h | 21 ++++++++++++++-------
>>  1 file changed, 14 insertions(+), 7 deletions(-)
>>
>> diff --git a/include/uapi/linux/psp-sev.h b/include/uapi/linux/psp-sev.h
>> index 832c15d9155bd..eeb20dfb1fdaa 100644
>> --- a/include/uapi/linux/psp-sev.h
>> +++ b/include/uapi/linux/psp-sev.h
>> @@ -73,13 +73,20 @@ typedef enum {
>>  	SEV_RET_INVALID_PARAM,
>>  	SEV_RET_RESOURCE_LIMIT,
>>  	SEV_RET_SECURE_DATA_INVALID,
>> -	SEV_RET_INVALID_KEY = 0x27,
>> -	SEV_RET_INVALID_PAGE_SIZE,
>> -	SEV_RET_INVALID_PAGE_STATE,
>> -	SEV_RET_INVALID_MDATA_ENTRY,
>> -	SEV_RET_INVALID_PAGE_OWNER,
>> -	SEV_RET_INVALID_PAGE_AEAD_OFLOW,
>> -	SEV_RET_RMP_INIT_REQUIRED,
>> +	SEV_RET_INVALID_PAGE_SIZE          = 0x0019,
>> +	SEV_RET_INVALID_PAGE_STATE         = 0x001A,
>> +	SEV_RET_INVALID_MDATA_ENTRY        = 0x001B,
>> +	SEV_RET_INVALID_PAGE_OWNER         = 0x001C,
>> +	SEV_RET_AEAD_OFLOW                 = 0x001D,
>> +	SEV_RET_EXIT_RING_BUFFER           = 0x001F,
>> +	SEV_RET_RMP_INIT_REQUIRED          = 0x0020,
>> +	SEV_RET_BAD_SVN                    = 0x0021,
>> +	SEV_RET_BAD_VERSION                = 0x0022,
>> +	SEV_RET_SHUTDOWN_REQUIRED          = 0x0023,
>> +	SEV_RET_UPDATE_FAILED              = 0x0024,
>> +	SEV_RET_RESTORE_REQUIRED           = 0x0025,
>> +	SEV_RET_RMP_INITIALIZATION_FAILED  = 0x0026,
>> +	SEV_RET_INVALID_KEY                = 0x0027,
>>  	SEV_RET_MAX,
>>  } sev_ret_code;
>>