linux-kernel - Re: [PATCH] Alpha: Emulate unaligned LDx_L/STx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEdQ38FX4M1hKMgmNJD7s_eVa4-_J6e9+xCqTw653wbw8BNPWw@mail.gmail.com>
Date: Thu, 20 Feb 2025 11:52:18 -0500
From: Matt Turner <mattst88@...il.com>
To: "Maciej W. Rozycki" <macro@...am.me.uk>
Cc: Richard Henderson <richard.henderson@...aro.org>, Ivan Kokshaysky <ink@...een.parts>, 
	Arnd Bergmann <arnd@...db.de>, John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>, 
	Magnus Lindholm <linmag7@...il.com>, "Paul E. McKenney" <paulmck@...nel.org>, 
	Linus Torvalds <torvalds@...ux-foundation.org>, Al Viro <viro@...iv.linux.org.uk>, 
	linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Alpha: Emulate unaligned LDx_L/STx_C for data consistency

On Thu, Feb 20, 2025 at 11:46 AM Matt Turner <mattst88@...il.com> wrote:
>
> On Wed, Feb 19, 2025 at 7:46 AM Maciej W. Rozycki <macro@...am.me.uk> wrote:
> >  #define OP_INT_MASK    ( 1L << 0x28 | 1L << 0x2c   /* ldl stl */       \
> > +                       | 1L << 0x2a | 1L << 0x2e   /* ldl_l stl_c */   \
> >                         | 1L << 0x29 | 1L << 0x2d   /* ldq stq */       \
> > +                       | 1L << 0x2b | 1L << 0x2f   /* ldq_l stq_c */   \
> >                         | 1L << 0x0c | 1L << 0x0d   /* ldwu stw */      \
> >                         | 1L << 0x0a | 1L << 0x0e ) /* ldbu stb */
> >
> >  #define OP_WRITE_MASK  ( 1L << 0x26 | 1L << 0x27   /* sts stt */       \
> >                         | 1L << 0x2c | 1L << 0x2d   /* stl stq */       \
> > +                       | 1L << 0x2e | 1L << 0x2d   /* stl_c stq_c */   \
>
> stq_c should be 0x2f, not 0x2d. Looks like a copy-n-paste mistake.

The good news is that OP_WRITE_MASK appears to be unused going all the
way back to the import into git, so this doesn't indicate a problem
with any of the testing that's been done.