linux-kernel - Re: [PATCH] media: i2c: imx219: remove context around case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPY8ntBNtz__=otVz_7b4cWBiHCoimBwij0EUUad8EXvTJ+8hQ@mail.gmail.com>
Date: Thu, 20 Feb 2025 17:14:40 +0000
From: Dave Stevenson <dave.stevenson@...pberrypi.com>
To: Cosmin Tanislav <demonsingur@...il.com>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: i2c: imx219: remove context around case

Hi Cosmin

Thanks for the patch.

On Thu, 20 Feb 2025 at 14:06, Cosmin Tanislav <demonsingur@...il.com> wrote:
>
> There are no longer variable declarations here, the context is useless.
>
> Signed-off-by: Cosmin Tanislav <demonsingur@...il.com>

Reviewed-by: Dave Stevenson <dave.stevenson@...pberrypi.com>

> ---
>  drivers/media/i2c/imx219.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index f662c9d755114..fcd98ee54768e 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -947,10 +947,9 @@ static int imx219_get_selection(struct v4l2_subdev *sd,
>                                 struct v4l2_subdev_selection *sel)
>  {
>         switch (sel->target) {
> -       case V4L2_SEL_TGT_CROP: {
> +       case V4L2_SEL_TGT_CROP:
>                 sel->r = *v4l2_subdev_state_get_crop(state, 0);
>                 return 0;
> -       }
>
>         case V4L2_SEL_TGT_NATIVE_SIZE:
>                 sel->r.top = 0;
> --
> 2.48.1
>