linux-kernel - Re: [PATCH v3] iio: light: Add check for array bounds in veml6075_read_int_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D7XJGM6MAB6N.2FYSUN4OJELUA@gmail.com>
Date: Thu, 20 Feb 2025 21:00:40 +0100
From: "Javier Carrasco" <javier.carrasco.cruz@...il.com>
To: "Karan Sanghavi" <karansanghvi98@...il.com>, "Jonathan Cameron"
 <jic23@...nel.org>, "Lars-Peter Clausen" <lars@...afoo.de>
Cc: <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Shuah
 Khan" <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3] iio: light: Add check for array bounds in
 veml6075_read_int_time_ms

On Thu Feb 20, 2025 at 6:34 PM CET, Karan Sanghavi wrote:
> The array contains only 5 elements, but the index calculated by
> veml6075_read_int_time_index can range from 0 to 7,
> which could lead to out-of-bounds access. The check prevents this issue.
>
> Coverity Issue
> CID 1574309: (#1 of 1): Out-of-bounds read (OVERRUN)
> overrun-local: Overrunning array veml6075_it_ms of 5 4-byte
> elements at element index 7 (byte offset 31) using
> index int_index (which evaluates to 7)
>
> Fixes: 3b82f43238ae ("iio: light: add VEML6075 UVA and UVB light sensor driver")
> Signed-off-by: Karan Sanghavi <karansanghvi98@...il.com>
> ---
>  drivers/iio/light/veml6075.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/veml6075.c b/drivers/iio/light/veml6075.c
> index 05d4c0e9015d..5dd951f6e989 100644
> --- a/drivers/iio/light/veml6075.c
> +++ b/drivers/iio/light/veml6075.c
> @@ -201,7 +201,12 @@ static int veml6075_read_int_time_index(struct veml6075_data *data)
>  	if (ret < 0)
>  		return ret;
>  
> -	return FIELD_GET(VEML6075_CONF_IT, conf);

Please declare the variable at the beginning of the function (there are
some integers there already) and rename it to follow the driver
convention, it for integration time: it_index

> +	int int_index = FIELD_GET(VEML6075_CONF_IT, conf);
> +
> +	if (int_index >= ARRAY_SIZE(veml6075_it_ms))
> +		return -EINVAL;
> +
> +	return int_index;
>  }
>  
>  static int veml6075_read_int_time_ms(struct veml6075_data *data, int *val)

With that applied:

Reviewed-by: Javier Carrasco <javier.carrasco@...il.com>