linux-kernel - [PATCH 1/1] fixup! mm: fix a crash due to vma_end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250220200208.323769-1-surenb@google.com>
Date: Thu, 20 Feb 2025 12:02:08 -0800
From: Suren Baghdasaryan <surenb@...gle.com>
To: akpm@...ux-foundation.org
Cc: sfr@...b.auug.org.au, hca@...ux.ibm.com, surenb@...gle.com, 
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: [PATCH 1/1] fixup! mm: fix a crash due to vma_end_read() that should
 have been removed

Handling a vma lock failure due to vma being detached from under us got
changed but vma_end_read() in that path was left untouched while it should
have been removed. Remove it.

Fixes: 758f7664c3d1 ("mm: replace vm_lock and detached flag with a reference count")
Reported-by: Heiko Carstens <hca@...ux.ibm.com>
Closes: https://lore.kernel.org/all/20250220185304.8313A7d-hca@linux.ibm.com/
Signed-off-by: Suren Baghdasaryan <surenb@...gle.com>
---
 mm/memory.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/memory.c b/mm/memory.c
index cacf6d53bdf3..567b45e5d149 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -6496,7 +6496,6 @@ struct vm_area_struct *lock_vma_under_rcu(struct mm_struct *mm,
 	if (IS_ERR_OR_NULL(vma)) {
 		/* Check if the VMA got isolated after we found it */
 		if (PTR_ERR(vma) == -EAGAIN) {
-			vma_end_read(vma);
 			count_vm_vma_lock_event(VMA_LOCK_MISS);
 			/* The area was replaced with another one */
 			goto retry;

base-commit: f7ed46277aaa8f848f18959ff68469f5186ba87c
-- 
2.48.1.601.g30ceb7b040-goog