linux-kernel - Re: [PATCH v2 3/3] drm/tiny: add driver for Apple Touch Bars in x86 Macs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2F0ACEE2-231F-426C-952E-975670AFC87D@live.com>
Date: Thu, 20 Feb 2025 20:41:05 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Neal Gompa <neal@...pa.dev>
CC: "pmladek@...e.com" <pmladek@...e.com>, "rostedt@...dmis.org"
	<rostedt@...dmis.org>, "andriy.shevchenko@...ux.intel.com"
	<andriy.shevchenko@...ux.intel.com>, "linux@...musvillemoes.dk"
	<linux@...musvillemoes.dk>, "senozhatsky@...omium.org"
	<senozhatsky@...omium.org>, "corbet@....net" <corbet@....net>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"mripard@...nel.org" <mripard@...nel.org>, "tzimmermann@...e.de"
	<tzimmermann@...e.de>, "airlied@...il.com" <airlied@...il.com>,
	"simona@...ll.ch" <simona@...ll.ch>, "akpm@...ux-foundation.org"
	<akpm@...ux-foundation.org>, "apw@...onical.com" <apw@...onical.com>,
	"joe@...ches.com" <joe@...ches.com>, "dwaipayanray1@...il.com"
	<dwaipayanray1@...il.com>, "lukas.bulwahn@...il.com"
	<lukas.bulwahn@...il.com>, "sumit.semwal@...aro.org"
	<sumit.semwal@...aro.org>, "christian.koenig@....com"
	<christian.koenig@....com>, "kekrby@...il.com" <kekrby@...il.com>,
	"admin@...eit.net" <admin@...eit.net>, Orlando Chamberlain
	<orlandoch.dev@...il.com>, "evepolonium@...il.com" <evepolonium@...il.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>, Hector
 Martin <marcan@...can.st>, "linux@...linux.org.uk" <linux@...linux.org.uk>,
	"asahi@...ts.linux.dev" <asahi@...ts.linux.dev>, Sven Peter
	<sven@...npeter.dev>, Janne Grunau <j@...nau.net>
Subject: Re: [PATCH v2 3/3] drm/tiny: add driver for Apple Touch Bars in x86
 Macs

Hi

> On 21 Feb 2025, at 12:04 AM, Neal Gompa <neal@...pa.dev> wrote:
> 
> On Thu, Feb 20, 2025 at 11:47 AM Aditya Garg <gargaditya08@...e.com> wrote:
>> 
>> From: Kerem Karabay <kekrby@...il.com>
>> 
>> The Touch Bars found on x86 Macs support two USB configurations: one
>> where the device presents itself as a HID keyboard and can display
>> predefined sets of keys, and one where the operating system has full
>> control over what is displayed.
>> 
>> This commit adds support for the display functionality of the second
>> configuration. Functionality for the first configuration has been
>> merged in the HID tree.
>> 
>> Note that this driver has only been tested on T2 Macs, and only includes
>> the USB device ID for these devices. Testing on T1 Macs would be
>> appreciated.
>> 
>> Credit goes to @imbushuo on GitHub for reverse engineering most of the
>> protocol.
>> 
> 
> Can we credit them as "Ben (Bingxing) Wang" instead? That's the name
> on their GitHub profile.

Sure I can change that. I’ll wait for a review on the driver itself as well, and incorporate this change along with other changes requested (if any).
> 
> 
> -- 
> 真実はいつも一つ！/ Always, there's only one truth!