linux-kernel - Re: [PATCH v2 01/15] cxl: Modify address translation callback for generic use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6db41e2e-4a88-4b1b-9cd3-6cb74ea2e846@intel.com>
Date: Thu, 20 Feb 2025 14:03:41 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Gregory Price <gourry@...rry.net>, Robert Richter <rrichter@....com>
Cc: Alison Schofield <alison.schofield@...el.com>,
 Vishal Verma <vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>,
 Dan Williams <dan.j.williams@...el.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Davidlohr Bueso <dave@...olabs.net>, linux-cxl@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 "Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>,
 Terry Bowman <terry.bowman@....com>
Subject: Re: [PATCH v2 01/15] cxl: Modify address translation callback for
 generic use

On 2/20/25 9:00 AM, Gregory Price wrote:
> On Tue, Feb 18, 2025 at 02:23:42PM +0100, Robert Richter wrote:
>> The root decoder address translation callback could be reused for
>> other decoders too. For generic use of the callback, change the
>> function interface to use a decoder argument instead of the root
>> decoder.
>>
>> Note that a root decoder's HPA is equal to its SPA, but else it may be
> 
> slighlty better wording:
> "but it may different for non-root decoders"

This change helped me understand what that sentence was trying to say.

> 
>> different. Thus, change the name of the function type to
>> cxl_to_hpa_fn.

I would also drop the "thus" so it's in imperative tone. 

>>
>> Signed-off-by: Robert Richter <rrichter@....com>
> 
> Reviewed-by: Gregory Price <gourry@...rry.net>
>