linux-kernel - Re: [PATCH] ata: Use str_up_down() helper in vt6420

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d20228bb-c1f4-4ebf-9010-e861e0ddceea@kernel.org>
Date: Thu, 20 Feb 2025 13:13:31 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Salah Triki <salah.triki@...il.com>, cassel@...nel.org,
 linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: Use str_up_down() helper in vt6420_prereset()

On 2/20/25 5:35 AM, Salah Triki wrote:
> Remove hard-coded strings by using the str_up_down() helper function.
> 
> Signed-off-by: Salah Triki <salah.triki@...il.com>

This looks OK but the patch title should be:

ata: sata_via: Use str_up_down() helper in vt6420_prereset()

With that fixed,

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>


-- 
Damien Le Moal
Western Digital Research