linux-kernel - Re: [PATCH] net/mlx5: Use secs_to_jiffies() instead of msecs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z7ek-uGw3IXH7bRM@x130>
Date: Thu, 20 Feb 2025 13:56:10 -0800
From: Saeed Mahameed <saeed@...nel.org>
To: Leon Romanovsky <leon@...nel.org>
Cc: Thorsten Blum <thorsten.blum@...ux.dev>,
	Jacob Keller <jacob.e.keller@...el.com>,
	Saeed Mahameed <saeedm@...dia.com>,
	Tariq Toukan <tariqt@...dia.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Yevgeny Kliteynik <kliteyn@...dia.com>,
	Mark Bloch <mbloch@...dia.com>, Itamar Gozlan <igozlan@...dia.com>,
	netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/mlx5: Use secs_to_jiffies() instead of
 msecs_to_jiffies()

On 20 Feb 14:07, Leon Romanovsky wrote:
>On Thu, Feb 20, 2025 at 12:08:07PM +0100, Thorsten Blum wrote:
>> On 20. Feb 2025, at 08:13, Leon Romanovsky wrote:
>> > On Wed, Feb 19, 2025 at 03:45:02PM -0800, Jacob Keller wrote:
>> >> On 2/19/2025 12:49 PM, Thorsten Blum wrote:
>> >>> Use secs_to_jiffies() and simplify the code.
>> >>>
>> >>> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
>> >>
>> >> nit: this is a cleanup which should have the net-next prefix applied,
>> >> since this doesn't fix any user visible behavior.
>> >>
>> >> Otherwise, seems like an ok change.
>> >
>> > IMHO, completely useless change for old code. I can see a value in new
>> > secs_to_jiffies() function for new code, but not for old code. I want
>> > to believe that people who write kernel patches aware that 1000 msec
>> > equal to 1 sec.
>>
>> Using secs_to_jiffies() is shorter and requires less cognitive load to
>> read imo. Plus, it now fits within the preferred 80 columns limit.

>Unfortunately, I see this change as a churn and not an improvement.

All patches with any justified improvement are welcome, as long as they are
not automated or bot generated spam.

This patch is reasonable, you need to add [PATCH net-next] prefix in
the title for this patch to get into the pipeline.

Feel free to add:
Reviewed-by: <saeed@...nel.org>

>
>>
>> This "old code" was added in d74ee6e197a2c ("net/mlx5: HWS, set timeout
>> on polling for completion") in January 2025.
>
>I got same conversion patches for RDMA.
>https://lore.kernel.org/all/20250219-rdma-secs-to-jiffies-v1-0-b506746561a9@linux.microsoft.com
>
>Thanks
>
>>
>> Thanks,
>> Thorsten
>>
>