linux-kernel - Re: [PATCH 1/1] objdump: Fix disassembly if CROSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250220221242.rdmfpabnhowjpu2m@jpoimboe>
Date: Thu, 20 Feb 2025 14:12:42 -0800
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: David Laight <david.laight.linux@...il.com>
Cc: linux-kernel@...r.kernel.org, Miroslav Benes <mbenes@...e.cz>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 1/1] objdump: Fix disassembly if CROSS_COMPILE not set

On Thu, Feb 20, 2025 at 02:11:59PM -0800, Josh Poimboeuf wrote:
> On Sat, Feb 15, 2025 at 02:23:21PM +0000, David Laight wrote:
> > If CROSS_COMPILE isn't set and -v specified the code tries to run
> > 	system("(null)objdump ....")
> > which really doesn't work very well.
> > Fix by changing NULL to "".
> > 
> > Fixes: ca653464dd097 ("objtool: Add verbose option for disassembling affected functions")
> > Signed-off-by: David Laight <david.laight.linux@...il.com>
> > ---
> >  tools/objtool/check.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> > index 753dbc4f8198..c1b771e772fd 100644
> > --- a/tools/objtool/check.c
> > +++ b/tools/objtool/check.c
> > @@ -4506,6 +4506,8 @@ static int disas_funcs(const char *funcs)
> >  	char *cmd;
> >  
> >  	cross_compile = getenv("CROSS_COMPILE");
> > +	if (!cross_compile)
> > +		cross_compile = "";
> 
> Makes sense, I'm not sure how this works for me already?  Regardless:
> 
> Acked-by: Josh Poimboeuf <jpoimboe@...nel.org>
> 
> Peter, can you take this one?

With s/objdump/objtool/ in subject :-)

-- 
Josh