linux-kernel - Re: [PATCH v2 2/3] hyperv: Change hv_root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a29af204-e4a9-4ef2-b5b8-f99f2ac0a836@linux.microsoft.com>
Date: Thu, 20 Feb 2025 14:56:53 -0800
From: Easwar Hariharan <eahariha@...ux.microsoft.com>
To: MUKESH RATHOR <mukeshrathor@...rosoft.com>
Cc: Nuno Das Neves <nunodasneves@...ux.microsoft.com>,
 "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
 "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
 "mhklinux@...look.com" <mhklinux@...look.com>, eahariha@...ux.microsoft.com,
 KY Srinivasan <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>,
 "wei.liu@...nel.org" <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
 "catalin.marinas@....com" <catalin.marinas@....com>,
 "will@...nel.org" <will@...nel.org>, "tglx@...utronix.de"
 <tglx@...utronix.de>, "mingo@...hat.com" <mingo@...hat.com>,
 "bp@...en8.de" <bp@...en8.de>,
 "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
 "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
 "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
 "joro@...tes.org" <joro@...tes.org>,
 "robin.murphy@....com" <robin.murphy@....com>, "arnd@...db.de"
 <arnd@...db.de>,
 "jinankjain@...ux.microsoft.com" <jinankjain@...ux.microsoft.com>,
 "muminulrussell@...il.com" <muminulrussell@...il.com>,
 "skinsburskii@...ux.microsoft.com" <skinsburskii@...ux.microsoft.com>
Subject: Re: [PATCH v2 2/3] hyperv: Change hv_root_partition into a function

On 2/20/2025 1:59 PM, MUKESH RATHOR wrote:
> 
> 
> On 2/20/25 10:33, Nuno Das Neves wrote:
>  > Introduce hv_current_partition_type to store the partition type
>  > as an enum.
>  >
>  > Right now this is limited to guest or root partition, but there will
>  > be other kinds in future and the enum is easily extensible.
>  >
>  > Set up hv_current_partition_type early in Hyper-V initialization with
>  > hv_identify_partition_type(). hv_root_partition() just queries this
>  > value, and shouldn't be called before that.
>  >
>  > Making this check into a function sets the stage for adding a config
>  > option to gate the compilation of root partition code. In particular,
>  > hv_root_partition() can be stubbed out always be false if root
>  > partition support isn't desired.
>  >
>  > Signed-off-by: Nuno Das Neves <nunodasneves@...ux.microsoft.com>
>  > ---
>  >   arch/arm64/hyperv/mshyperv.c       |  2 ++
>  >   arch/x86/hyperv/hv_init.c          | 10 ++++-----
>  >   arch/x86/kernel/cpu/mshyperv.c     | 24 ++------------------
>  >   drivers/clocksource/hyperv_timer.c |  4 ++--
>  >   drivers/hv/hv.c                    | 10 ++++-----
>  >   drivers/hv/hv_common.c             | 35 +++++++++++++++++++++++++-----
>  >   drivers/hv/vmbus_drv.c             |  2 +-
>  >   drivers/iommu/hyperv-iommu.c       |  4 ++--
>  >   include/asm-generic/mshyperv.h     | 15 +++++++++++--
>  >   9 files changed, 61 insertions(+), 45 deletions(-)
>  >

<snip>

>  > @@ -34,8 +34,11 @@
>  >   u64 hv_current_partition_id = HV_PARTITION_ID_SELF;
>  >   EXPORT_SYMBOL_GPL(hv_current_partition_id);
>  >
>  > +enum hv_partition_type hv_current_partition_type;
>  > +EXPORT_SYMBOL_GPL(hv_current_partition_type);
>  > +
> 
> nit: if possible and not too late, can we please use more Unix
> style naming, eg, hv_curr_ptid and hv_curr_pt_type rather than this
> long windows style names that causes unnecessary line wraps/splits.
> 
> Thanks,
> -Mukesh
> 

Per https://docs.kernel.org/process/coding-style.html#naming

GLOBAL variables (to be used only if you really need them) need to have descriptive names,
as do global functions. If you have a function that counts the number of active users,
you should call that count_active_users() or similar, you should not call it cntusr().

Thanks,
Easwar (he/him)