linux-kernel - Re: [PATCH net-next v2] tun: Pad virtio headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: 
 <174009304478.1506397.8001698369516362752.git-patchwork-notify@kernel.org>
Date: Thu, 20 Feb 2025 23:10:44 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Akihiko Odaki <akihiko.odaki@...nix.com>
Cc: corbet@....net, willemdebruijn.kernel@...il.com, jasowang@...hat.com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 mst@...hat.com, xuanzhuo@...ux.alibaba.com, shuah@...nel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, kvm@...r.kernel.org,
 virtualization@...ts.linux-foundation.org, linux-kselftest@...r.kernel.org,
 yuri.benditovich@...nix.com, andrew@...nix.com, stephen@...workplumber.org,
 gur.stavi@...wei.com, devel@...nix.com
Subject: Re: [PATCH net-next v2] tun: Pad virtio headers

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Sat, 15 Feb 2025 15:04:50 +0900 you wrote:
> tun simply advances iov_iter when it needs to pad virtio header,
> which leaves the garbage in the buffer as is. This will become
> especially problematic when tun starts to allow enabling the hash
> reporting feature; even if the feature is enabled, the packet may lack a
> hash value and may contain a hole in the virtio header because the
> packet arrived before the feature gets enabled or does not contain the
> header fields to be hashed. If the hole is not filled with zero, it is
> impossible to tell if the packet lacks a hash value.
> 
> [...]

Here is the summary with links:
  - [net-next,v2] tun: Pad virtio headers
    https://git.kernel.org/netdev/net-next/c/4adf74971018

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html