linux-kernel - Re: [PATCH v2 net-next 2/6] net: hibmcge: Add rx checksum offload supported in this module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250220151136.2cb46929@kernel.org>
Date: Thu, 20 Feb 2025 15:11:36 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <andrew+netdev@...n.ch>, <horms@...nel.org>, <shenjian15@...wei.com>,
 <wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>,
 <chenhao418@...wei.com>, <sudongming1@...wei.com>, <xujunsheng@...wei.com>,
 <shiyongbang@...wei.com>, <libaihan@...wei.com>,
 <jonathan.cameron@...wei.com>, <shameerali.kolothum.thodi@...wei.com>,
 <salil.mehta@...wei.com>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 2/6] net: hibmcge: Add rx checksum offload
 supported in this module

On Tue, 18 Feb 2025 16:58:25 +0800 Jijie Shao wrote:
> +static netdev_features_t hbg_net_fix_features(struct net_device *netdev,
> +					      netdev_features_t features)
> +{
> +	return features & HBG_SUPPORT_FEATURES;
> +}

Do you need this? Why would the stack try to set features you don't
support/advertize? Also you may clear SW features unnecessarily this
way.
-- 
pw-bot: cr