linux-kernel - Re: [PATCH net-next v1 1/1] ppp: Fix KMSAN warning by initializing 2-byte header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250220152703.619bf1c9@kernel.org>
Date: Thu, 20 Feb 2025 15:27:03 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jiayuan Chen <jiayuan.chen@...ux.dev>
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, andrew+netdev@...n.ch,
 davem@...emloft.ne, edumazet@...gle.com, pabeni@...hat.com,
 horms@...nel.org, ricardo@...liere.net, viro@...iv.linux.org.uk,
 dmantipov@...dex.ru, aleksander.lobakin@...el.com,
 linux-ppp@...r.kernel.org, linux-kernel@...r.kernel.org, mrpre@....com,
 syzbot+853242d9c9917165d791@...kaller.appspotmail.com
Subject: Re: [PATCH net-next v1 1/1] ppp: Fix KMSAN warning by initializing
 2-byte header

On Tue, 18 Feb 2025 21:31:44 +0800 Jiayuan Chen wrote:
> -		*(u8 *)skb_push(skb, 2) = 1;
> +		*(u16 *)skb_push(skb, 2) = 1;

This will write the 1 to a different byte now, on big endian machines.
Probably doesn't matter but I doubt it's intentional?
-- 
pw-bot: cr