| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID:
<MA0PR01MB567180C0FE89E3BEBAF2B12EFEC42@MA0PR01MB5671.INDPRD01.PROD.OUTLOOK.COM>
Date: Fri, 21 Feb 2025 07:35:51 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Bartosz Golaszewski <brgl@...ev.pl>, Yixun Lan <dlan@...too.org>
Cc: Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Meng Zhang <zhangmeng.kevin@...ux.spacemit.com>, linux-gpio@...r.kernel.org,
Linus Walleij <linus.walleij@...aro.org>, linux-kernel@...r.kernel.org,
Conor Dooley <conor@...nel.org>, Yangyu Chen <cyy@...self.name>,
devicetree@...r.kernel.org, Palmer Dabbelt <palmer@...belt.com>,
Jesse Taube <mr.bossman075@...il.com>, Jisheng Zhang <jszhang@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>,
Inochi Amaoto <inochiama@...look.com>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, spacemit@...ts.linux.dev,
linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v5 3/5] gpio: spacemit: add support for K1 SoC
On 2025/2/20 21:34, Bartosz Golaszewski wrote:
> On Mon, Feb 17, 2025 at 1:58 PM Yixun Lan <dlan@...too.org> wrote:
[......]
>> +#define to_spacemit_gpio_bank(x) container_of((x), struct spacemit_gpio_bank, gc)
>> +
>> +struct spacemit_gpio;
>> +
>> +struct spacemit_gpio_bank {
>> + struct gpio_chip gc;
>> + struct spacemit_gpio *sg;
>> + void __iomem *base;
>> + u32 index;
>> + u32 irq_mask;
>> + u32 irq_rising_edge;
>> + u32 irq_falling_edge;
>> +};
>> +
>> +struct spacemit_gpio {
>> + struct device *dev;
>> + struct spacemit_gpio_bank sgb[NR_BANKS];
>> +};
> Please don't use tabs in struct definitions.
Why not？I see
https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#struct-declarations-and-initializers
[......]
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
Powered by blists - more mailing lists