linux-kernel - Re: [PATCH][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98f1cc71-7699-40f5-909f-86e7317d8071@gmail.com>
Date: Thu, 20 Feb 2025 09:41:06 +0200
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>, "Gustavo A. R. Silva"
 <gustavo@...eddedor.com>, "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
 Tariq Toukan <tariqt@...dia.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] net/mlx5e: Avoid a hundred
 -Wflex-array-member-not-at-end warnings



On 20/02/2025 3:46, Jakub Kicinski wrote:
> On Wed, 19 Feb 2025 14:14:35 +0200 Tariq Toukan wrote:
>> On 18/02/2025 23:13, Jakub Kicinski wrote:
>>> On Tue, 18 Feb 2025 17:53:14 +0200 Tariq Toukan wrote:
>>>> Maybe it wasn't clear enough.
>>>> We prefer the original patch, and provided the Reviewed-by tag for it.
>>>
>>> Can you explain what do you mean by "cleaner"?
>>> I like the alternative much more.
>>
>> Cleaner in the sense that it doesn't touch existing code in en_rx.c
>> (datapath), and has shorter dereferences for the inner umr_wqe fields, like:
>> umr_wqe->ctrl
>> vs.
>> umr_wqe->hdr.ctrl
> 
> IMO that's minor, not sufficient to justify struct_group_tagged()

No strong preference. I can accept both.