linux-kernel - Re: [PATCH v4 0/2] hwmon:(ina238)Add support for SQ52206

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250220074632.5003-1-wenliang202407@163.com>
Date: Thu, 20 Feb 2025 02:46:32 -0500
From: Wenliang Yan <wenliang202407@....com>
To: linux@...ck-us.net
Cc: christophe.jaillet@...adoo.fr,
	conor+dt@...nel.org,
	corbet@....net,
	jdelvare@...e.com,
	krzk+dt@...nel.org,
	linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	robh@...nel.org,
	wenliang202407@....com
Subject: Re: [PATCH v4 0/2] hwmon:(ina238)Add support for SQ52206

At 2025-01-25 13:01:36, "Guenter Roeck" <linux@...ck-us.net> wrote:
>On 1/24/25 19:02, Wenliang Yan wrote:
>> Add support for Silergy i2c power monitor SQ52206 to the ina238
>> driver as those two are similar.
>> 
>> Signed-off-by: Wenliang Yan <wenliang202407@....com>
>> ---
>> 
>> Add new chip SQ52206, the datasheet depends on
>> https://us1.silergy.com/cloud/index/uniqid/676b659b4a503
>> The password is fx6NEe.
>> 
>> Changes in v4:
>> - addressed various review comments.
>> - Link to v3: https://lore.kernel.org/linux-hwmon/20250117082017.688212-1-wenliang202407@163.com/
>> 
>
>Your "change logs" are equivalent to "made changes" and completely pointless.
>As consequence, I'll only handle your patches if and when I have nothing else
>to review since I'll have to figure out myself what you changed and if you
>implemented the feedback. I don't really hve time for that, so please do not
>expect that I'll apply this series anytime soon.
>
>Guenter

Sorry to bother you. I'm not sure if the description of the "change log" in
the email I replied to you on January 25th was still too brief
(https://lore.kernel.org/linux-hwmon/20250125064432.1242713-1-
wenliang202407@....com/). 
Therefore, I have added more content again, hoping it will be helpful to you.
At the same time, if you think any part needs adjustment, I will cooperate
actively. Looking forward to your reply.

There are two main changes in the V4 version:

1) add 'Acked-by: Krzysztof Kozlowski' information to PATCH 1.

2) formatting adjustments have been made to ina2xx.c in PATCH2 with
Christophe JAILLET's comments.(https://lore.kernel.org/linux-hwmon/
5f4095b0-8105-4001-81ac-e4f7053e45ae@...adoo.fr/)

Including:

1.Change 'sprintf()' in the 'energy1_input_show()' to 'sysfs_emit()'.

2.Move up the "enum ina238_ids chip" line in the 'ina238_probe()'
to keep RCT style

3.Remove the last comma when describing 'ina238_of_match[]' to keep the
format consistent with the 'i2c_device_id ina238_id[]' structure

4.Change the '5bytes' in the description to '5 bytes'

Thanks,
Wenliang Yan

>> Changes in v3:
>> - addressed various review comments.
>> - Link to v2: https://lore.kernel.org/linux-hwmon/20250113035023.365697-1-wenliang202407@163.com/
>> 
>> Changes in v2:
>> - Explain why sq52206 compatibility has been added to ina2xx.yaml.
>> - addressed various review comments
>> - Link to v1: https://lore.kernel.org/linux-hwmon/20241224063559.391061-1-wenliang202407@163.com/
>> 
>> Wenliang Yan (2):
>>    dt-bindings:Add SQ52206 to ina2xx devicetree bindings
>>    hwmon:(ina238)Add support for SQ52206
>> 
>>   .../devicetree/bindings/hwmon/ti,ina2xx.yaml  |   4 +
>>   Documentation/hwmon/ina238.rst                |  15 ++
>>   drivers/hwmon/ina238.c                        | 209 +++++++++++++++---
>>   3 files changed, 195 insertions(+), 33 deletions(-)
>>