linux-kernel - Re: [PATCH RESEND v2 1/4] dt-bindings: i3c: silvaco: Add npcm845 compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <749d3e3c-8589-4fd8-a472-cf6b225193c8@kernel.org>
Date: Thu, 20 Feb 2025 09:19:07 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Stanley Chu <stanley.chuys@...il.com>, frank.li@....com,
 miquel.raynal@...tlin.com, alexandre.belloni@...tlin.com,
 linux-i3c@...ts.infradead.org
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 tomer.maimon@...oton.com, kwliu@...oton.com, yschu@...oton.com
Subject: Re: [PATCH RESEND v2 1/4] dt-bindings: i3c: silvaco: Add npcm845
 compatible string

On 20/02/2025 07:11, Stanley Chu wrote:
> From: Stanley Chu <yschu@...oton.com>
> 
> Add a compatible string for Nuvoton BMC NPCM845 i3c controller.

This we see from the diff. Say something useful, is it compatible with
other? Why is it in the same binding?

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
</form letter>

> 
> Signed-off-by: Stanley Chu <yschu@...oton.com>
> ---
>  Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> index c56ff77677f1..9be4bc4cc482 100644
> --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> @@ -14,7 +14,9 @@ allOf:
>  
>  properties:
>    compatible:
> -    const: silvaco,i3c-master-v1
> +    enum:
> +      - silvaco,i3c-master-v1
> +      - nuvoton,npcm845-i3c

Keep alphabetical order.

Best regards,
Krzysztof