linux-kernel - Re: [PATCH v2 3/3] dt-bindings: hwmon: emc2305: Add YAML binding documentation for emc2305 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14863a52-f2ab-42ef-be86-b9da2a8d76df@kernel.org>
Date: Thu, 20 Feb 2025 09:31:20 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Guenter Roeck <linux@...ck-us.net>, florin.leotescu@....nxp.com,
 Jean Delvare <jdelvare@...e.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Michael Shych <michaelsh@...dia.com>,
 linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: viorel.suman@....com, carlos.song@....com,
 linux-arm-kernel@...ts.infradead.org, imx@...ts.linux.dev,
 Florin Leotescu <florin.leotescu@....com>
Subject: Re: [PATCH v2 3/3] dt-bindings: hwmon: emc2305: Add YAML binding
 documentation for emc2305 driver

On 19/02/2025 16:52, Guenter Roeck wrote:
> On 2/19/25 06:01, Krzysztof Kozlowski wrote:
> [ ... ]
> 
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - hwmon,emc2301
>>> +      - hwmon,emc2302
>>> +      - hwmon,emc2303
>>> +      - hwmon,emc2305
>>
>> Nope.
>>
>> Was it ever internally reviewed?
>>
> No. I intentionally do not review bindings because I notoriously get it wrong,
> and instead rely on DT maintainers.
> 
> I agree though that this one is really bad :-(


Wait, my comment was not towards you, but towards NXP and their internal
review. NXP is a big company, not individual contributor, so they should
use internal review to catch obvious issues instead of using community
resources for such trivial tasks.

Best regards,
Krzysztof