linux-kernel - Re: [PATCH v6 27/42] x86/resctrl: Move RFTYPE flags to be managed by resctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5424ecd1-6a6b-4ed9-87cb-845036c23fb8@intel.com>
Date: Wed, 19 Feb 2025 17:17:40 -0800
From: Reinette Chatre <reinette.chatre@...el.com>
To: James Morse <james.morse@....com>, <x86@...nel.org>,
	<linux-kernel@...r.kernel.org>
CC: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	Borislav Petkov <bp@...en8.de>, H Peter Anvin <hpa@...or.com>, Babu Moger
	<Babu.Moger@....com>, <shameerali.kolothum.thodi@...wei.com>, "D Scott
 Phillips OS" <scott@...amperecomputing.com>, <carl@...amperecomputing.com>,
	<lcherian@...vell.com>, <bobo.shaobowang@...wei.com>,
	<tan.shaopeng@...itsu.com>, <baolin.wang@...ux.alibaba.com>, Jamie Iles
	<quic_jiles@...cinc.com>, Xin Hao <xhao@...ux.alibaba.com>,
	<peternewman@...gle.com>, <dfustini@...libre.com>, <amitsinght@...vell.com>,
	David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>,
	"Dave Martin" <dave.martin@....com>, Koba Ko <kobak@...dia.com>, Shanker
 Donthineni <sdonthineni@...dia.com>
Subject: Re: [PATCH v6 27/42] x86/resctrl: Move RFTYPE flags to be managed by
 resctrl

Hi James,

On 2/7/25 10:18 AM, James Morse wrote:
> resctrl_file_fflags_init() is called from the architecture specific code
> to make the 'thread_throttle_mode' file visible. The architecture specific
> code has already set the membw.throttle_mode in the rdt_resource.
> 
> This forces the RFTYPE flags used by resctrl to be exposed to the
> architecture specific code.
> 
> This doesn't need to be specific to the architecture, the throttle_mode
> can be used by resctrl to determine if the 'thread_throttle_mode' file
> should be visible. This allows the RFTYPE flags to be private to resctrl.
> 
> Add thread_throttle_mode_init(), and use it to call
> resctrl_file_fflags_init()  from resctrl_setup(). This avoids

"  from resctrl_setup()" -> " from resctrl_init()" ?

> publishing an extra function between the architecture and filesystem
> code.
> 
> Signed-off-by: James Morse <james.morse@....com>
> ---

| Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette