linux-kernel - Re: [PATCH v2] auxdisplay: MAX6959 should select BITREVERSE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXxu_H52JJPwwU-GSNA=J0qQ8oJtU53+gEidukTaFhseg@mail.gmail.com>
Date: Thu, 20 Feb 2025 10:07:52 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Andy Shevchenko <andy@...nel.org>, linux-kernel@...r.kernel.org, 
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2] auxdisplay: MAX6959 should select BITREVERSE

Hi Andy,

On Thu, 20 Feb 2025 at 09:21, Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> On Thu, Feb 20, 2025 at 9:48 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> >
> > If CONFIG_BITREVERSE is not enabled:
> >
> >     max6959.c:(.text+0x92): undefined reference to `byte_rev_table'
>
> LGTM now, thanks.
> Do you think we are in an emergency to send it for v6.14?

No.

> If possible, I would prefer to send this in PR for v6.15 as the
> problem was from day 1 and only bitbot found the configuration so far
> that fails to build.

I had to go through lots of loops to disable BITREVERSE and reproduce
the build issue (e.g. CRC32 selects BITREVERSE), so I doubt anyone
will ever encounter it with a real config.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds