linux-kernel - Re: [PATCH] drm/arm/komeda: Add a condition check before removing sysfs attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250220-spiked-quirky-nightingale-6ad2ed@houat>
Date: Thu, 20 Feb 2025 10:43:23 +0100
From: Maxime Ripard <mripard@...nel.org>
To: Shixiong Ou <oushixiong1025@....com>
Cc: Liviu Dudau <liviu.dudau@....com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Thomas Zimmermann <tzimmermann@...e.de>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, Shixiong Ou <oushixiong@...inos.cn>
Subject: Re: [PATCH] drm/arm/komeda: Add a condition check before removing
 sysfs attribute

On Thu, Feb 20, 2025 at 05:20:48PM +0800, Shixiong Ou wrote:
> 
> 在 2025/2/20 17:12, Maxime Ripard 写道:
> > On Thu, Feb 20, 2025 at 04:53:58PM +0800,oushixiong1025@....com  wrote:
> > > From: Shixiong Ou<oushixiong@...inos.cn>
> > > 
> > > [WHY] If the call to sysfs_create_group() fails, there is
> > >        no need to call function sysfs_remove_group().
> > > 
> > > [HOW] Add a condition check before removing sysfs attribute.
> > > 
> > > Signed-off-by: Shixiong Ou<oushixiong@...inos.cn>
> > What are you trying to fix exactly? AFAIK, there's no code path that
> > calls komeda_dev_destroy() after komeda_dev_create() has failed.
>
> |if calling |||sysfs_create_group() fails, it will go to lable
> 'err_cleanup:', and it will call |komeda_dev_destroy() laterly.

Ah, right. Then that's what you should fix.

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (274 bytes)