linux-kernel - [PATCH] hwmon: (ad7314) Validate leading zero bit and return error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <c54ef4dd7b562268768200239b00441a74b547c3.camel@iris-sensing.com>
Date: Thu, 20 Feb 2025 10:18:17 +0000
From: Erik Schumacher <erik.schumacher@...s-sensing.com>
CC: "linux@...ck-us.net" <linux@...ck-us.net>, "linux-hwmon@...r.kernel.org"
	<linux-hwmon@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "jdelvare@...e.com" <jdelvare@...e.com>
Subject: [PATCH] hwmon: (ad7314) Validate leading zero bit and return error

A leading zero bit is sent on the bus before the temperature value is
transmitted. If this bit is high, the connection might be unstable or it
could mean that no AD7314 (or compatible) is connected on the bus.
Return -ENXIO in that case.

Signed-off-by: Erik Schumacher <erik.schumacher@...s-sensing.com>
---
 drivers/hwmon/ad7314.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/hwmon/ad7314.c b/drivers/hwmon/ad7314.c
index 7802bbf5f958..025846f1f18b 100644
--- a/drivers/hwmon/ad7314.c
+++ b/drivers/hwmon/ad7314.c
@@ -65,6 +65,10 @@ static ssize_t ad7314_temperature_show(struct device *dev,
 		return ret;
 	switch (spi_get_device_id(chip->spi_dev)->driver_data) {
 	case ad7314:
+		if (ret & BIT(15)) {
+			/* Invalid read-out, leading zero bit is missing */
+			return -ENXIO;
+		}
 		data = (ret & AD7314_TEMP_MASK) >> AD7314_TEMP_SHIFT;
 		data = sign_extend32(data, 9);
 
-- 
2.48.1