linux-kernel - Re: [PATCH V3 5/6] tpm: Add a driver for Loongson TPM device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e0a3b40-07b8-06bf-8814-a121308ebf69@loongson.cn>
Date: Thu, 20 Feb 2025 19:23:42 +0800
From: Qunqin Zhao <zhaoqunqin@...ngson.cn>
To: Jarkko Sakkinen <jarkko@...nel.org>
Cc: lee@...nel.org, herbert@...dor.apana.org.au, davem@...emloft.net,
 peterhuewe@....de, linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev,
 linux-crypto@...r.kernel.org, jgg@...pe.ca, linux-integrity@...r.kernel.org,
 Yinggang Gu <guyinggang@...ngson.cn>
Subject: Re: [PATCH V3 5/6] tpm: Add a driver for Loongson TPM device


在 2025/2/19 下午9:44, Jarkko Sakkinen 写道:
>> +
>> +static const struct tpm_class_ops lsse_tpm_ops = {
>> +	.flags = TPM_OPS_AUTO_STARTUP,
>> +	.recv = tpm_ls_recv,
>> +	.send = tpm_ls_send,
>> +};
>> +
>> +static int lsse_tpm_probe(struct platform_device *pdev)
> tpm_lsse_
OK.
> +
> +static struct platform_driver lsse_tpm_driver = {
> +	.probe   = lsse_tpm_probe,
> +	.driver  = {
> +		.name  = "ls6000se-tpm",
> +	},
> +};
> +module_platform_driver(lsse_tpm_driver);
> +
> +MODULE_ALIAS("platform:ls6000se-tpm");
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Yinggang Gu <guyinggang@...ngson.cn>");
> +MODULE_AUTHOR("Qunqin Zhao <zhaoqunqin@...ngson.cn>");
> Remove MODULE_AUTHOR fields. Git encodes this already.

Do you mean that "modinfo" will still show the author after removing 
MODULE_AUTHOR fields?

>
>> +MODULE_DESCRIPTION("Loongson TPM driver");
>> -- 
>> 2.43.0
>>
> Prefix all with tpm_lsse instead of tpm

OK, thanks for your comments.

BR, Qunqin.

>
> BR, Jarkko