linux-kernel - Re: [PATCH v5 1/2] dt-bindings: net: bluetooth: nxp: Add support to set BD address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <184919f9-25bd-4f65-9ed9-dc452a6f4418@molgen.mpg.de>
Date: Thu, 20 Feb 2025 12:45:03 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
Cc: marcel@...tmann.org, luiz.dentz@...il.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, linux-bluetooth@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 amitkumar.karwar@....com, sherry.sun@....com, ziniu.wang_1@....com,
 johan.korsnes@...arkable.no, kristian.krohn@...arkable.no,
 manjeet.gupta@....com
Subject: Re: [PATCH v5 1/2] dt-bindings: net: bluetooth: nxp: Add support to
 set BD address

Dear Neeraj,


Thank you for your patch.


Am 20.02.25 um 12:41 schrieb Neeraj Sanjay Kale:
> Allow user to set custom BD address for NXP chipsets.
> 
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
> v2: Add allOf and unevaluatedProperties: false (Krzysztof)
> v3: Drop local-bd-address: true (Krzysztof)
> ---
>   .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml   | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> index 0a2d7baf5db3..a84c1c21b024 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> @@ -17,6 +17,9 @@ description:
>   maintainers:
>     - Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
>   
> +allOf:
> +  - $ref: bluetooth-controller.yaml#
> +
>   properties:
>     compatible:
>       enum:
> @@ -43,7 +46,7 @@ properties:
>   required:
>     - compatible
>   
> -additionalProperties: false
> +unevaluatedProperties: false

How is this diff related to the change mentioned in the commit message?

>   
>   examples:
>     - |
> @@ -54,5 +57,6 @@ examples:
>               fw-init-baudrate = <3000000>;
>               firmware-name = "uartuart8987_bt_v0.bin";
>               device-wakeup-gpios = <&gpio 11 GPIO_ACTIVE_HIGH>;
> +            local-bd-address = [66 55 44 33 22 11];
>           };
>       };


Kind regards,

Paul