linux-kernel - Re: [PATCH 2/6] drivers: base: devres: Fix find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025022033-struck-employee-1960@gregkh>
Date: Thu, 20 Feb 2025 13:24:37 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Lucas De Marchi <lucas.demarchi@...el.com>
Cc: linux-kernel@...r.kernel.org, Rodrigo Vivi <rodrigo.vivi@...el.com>,
	dri-devel@...ts.freedesktop.org, Danilo Krummrich <dakr@...nel.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH 2/6] drivers: base: devres: Fix find_group() documentation

On Wed, Feb 12, 2025 at 12:05:38PM -0800, Lucas De Marchi wrote:
> It returns the last open group, not the last group.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@...el.com>
> ---
>  drivers/base/devres.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/base/devres.c b/drivers/base/devres.c
> index b955a2f9520bf..d8a733ea5e1ac 100644
> --- a/drivers/base/devres.c
> +++ b/drivers/base/devres.c
> @@ -576,7 +576,10 @@ void *devres_open_group(struct device *dev, void *id, gfp_t gfp)
>  }
>  EXPORT_SYMBOL_GPL(devres_open_group);
>  
> -/* Find devres group with ID @id.  If @id is NULL, look for the latest. */
> +/*
> + * Find devres group with ID @id.  If @id is NULL, look for the latest open
> + * group.
> + */
>  static struct devres_group *find_group(struct device *dev, void *id)
>  {
>  	struct devres_node *node;
> -- 
> 2.48.1
> 

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>