linux-kernel - Re: [PATCH v5 1/2] dt-bindings: net: bluetooth: nxp: Add support to set BD address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AS4PR04MB96928A5C527D1720B9BE0AE0E7C42@AS4PR04MB9692.eurprd04.prod.outlook.com>
Date: Thu, 20 Feb 2025 12:30:58 +0000
From: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
CC: "marcel@...tmann.org" <marcel@...tmann.org>, "luiz.dentz@...il.com"
	<luiz.dentz@...il.com>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, "linux-bluetooth@...r.kernel.org"
	<linux-bluetooth@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, Amitkumar Karwar <amitkumar.karwar@....com>,
	Sherry Sun <sherry.sun@....com>, Luke Wang <ziniu.wang_1@....com>,
	"johan.korsnes@...arkable.no" <johan.korsnes@...arkable.no>,
	"kristian.krohn@...arkable.no" <kristian.krohn@...arkable.no>, Manjeet Gupta
	<manjeet.gupta@....com>
Subject: Re: [PATCH v5 1/2] dt-bindings: net: bluetooth: nxp: Add support to
 set BD address

Hi Paul,
 
> >> Am 20.02.25 um 12:41 schrieb Neeraj Sanjay Kale:
> >>> Allow user to set custom BD address for NXP chipsets.
> >>>
> >>> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >>> ---
> >>> v2: Add allOf and unevaluatedProperties: false (Krzysztof)
> >>> v3: Drop local-bd-address: true (Krzysztof)
> >>> ---
> >>>    .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml   | 6 +++++-
> >>>    1 file changed, 5 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git
> >> a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
> bt.yaml
> >> b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
> bt.yaml
> >>> index 0a2d7baf5db3..a84c1c21b024 100644
> >>> ---
> >>> a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
> bt.yam
> >>> l
> >>> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-
> bt
> >>> +++ .yaml
> >>> @@ -17,6 +17,9 @@ description:
> >>>    maintainers:
> >>>      - Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
> >>>
> >>> +allOf:
> >>> +  - $ref: bluetooth-controller.yaml#
> >>> +
> >>>    properties:
> >>>      compatible:
> >>>        enum:
> >>> @@ -43,7 +46,7 @@ properties:
> >>>    required:
> >>>      - compatible
> >>>
> >>> -additionalProperties: false
> >>> +unevaluatedProperties: false
> >>
> >> How is this diff related to the change mentioned in the commit message?
> >
> > This is based on review comment from Krzysztof in V1 DT patch.
> > allOf ref will import all properties defined in bluetooth-controller.yaml,
> including local-bd-address:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> >
> ub.com%2Ftorvalds%2Flinux%2Fblob%2Fmaster%2FDocumentation%2Fdevic
> etree
> > %2Fbindings%2Fnet%2Fbluetooth%2Fbluetooth-
> controller.yaml%23L18&data=0
> >
> 5%7C02%7Cneeraj.sanjaykale%40nxp.com%7Cea6b9bba11954062a8ab08dd5
> 1a7c28
> >
> 9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638756503156741
> 597%7CUn
> >
> known%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAw
> MCIsIlAiOi
> >
> JXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=Nf
> 5EkxiY
> > rHPZQjCBa1XFeu8Y5T8cXpQwXHZ757YvGFw%3D&reserved=0
> 
> Thank you. I'd include this in the commit message, but my comment was
> about the replacement of `additionalProperties` by `unevaluatedProperties`.
As per DT documentation, if we include other schemas, we must use "unevaluatedProperties:false" instead of "additionalProperties:false"

https://docs.kernel.org/devicetree/bindings/writing-bindings.html

With "additionalProperties:false", make dt_binding_check fails as it is unable to find the 'local-bd-address' property.

> 
> >>>
> >>>    examples:
> >>>      - |
> >>> @@ -54,5 +57,6 @@ examples:
> >>>                fw-init-baudrate = <3000000>;
> >>>                firmware-name = "uartuart8987_bt_v0.bin";
> >>>                device-wakeup-gpios = <&gpio 11 GPIO_ACTIVE_HIGH>;
> >>> +            local-bd-address = [66 55 44 33 22 11];
> >>>            };
> >>>        };
> 

Thanks,
Neeraj