linux-kernel - [PATCH v5] dma: dw-axi-dmac: remove unnecessary axi_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250220124122.3807306-1-niravkumar.l.rabara@intel.com>
Date: Thu, 20 Feb 2025 20:41:22 +0800
From: niravkumar.l.rabara@...el.com
To: Vinod Koul <vkoul@...nel.org>,
	Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>
Cc: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>,
	nirav.rabara@...era.com,
	dmaengine@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Jisheng Zhang <jszhang@...nel.org>
Subject: [PATCH v5] dma: dw-axi-dmac: remove unnecessary axi_dma_enable() calling

From: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>

DMA is always enabled before calling axi_chan_block_xfer_start(),
so it does not need to be enabled again here.

Re-enabling DMA causes random failures in the dmatest test when running
multiple iterations.
e.g.
[   29.600722] dmatest: dma0chan2-copy0: summary 100 tests, 1 failures 160.26 iops 1299 KB/s (0)

Fixes: 1fe20f1b8454 ("dmaengine: Introduce DW AXI DMAC driver")
Tested-by: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>
Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>
---
Changes in v5:
  * Fixed the Tested-by format.

Changes in v4:
  * Add fixes tag
  * Rebase to v6.14-rc1 

link to v3:
 - https://lore.kernel.org/all/20230521101216.4084-4-jszhang@kernel.org/

 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index b23536645ff7..43d30c7b8f03 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -435,8 +435,6 @@ static void axi_chan_block_xfer_start(struct axi_dma_chan *chan,
 		return;
 	}
 
-	axi_dma_enable(chan->chip);
-
 	config.dst_multblk_type = DWAXIDMAC_MBLK_TYPE_LL;
 	config.src_multblk_type = DWAXIDMAC_MBLK_TYPE_LL;
 	config.tt_fc = DWAXIDMAC_TT_FC_MEM_TO_MEM_DMAC;
-- 
2.25.1