linux-kernel - Re: [PATCH v4] intel_idle: introduce 'no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b67088de0b6a24a67cfe0a1860011d290307c08.camel@gmail.com>
Date: Thu, 20 Feb 2025 14:50:44 +0200
From: Artem Bityutskiy <dedekind1@...il.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>, David Arcari
 <darcari@...hat.com>
Cc: linux-pm@...r.kernel.org, Jonathan Corbet <corbet@....net>, Jacob Pan
 <jacob.jun.pan@...ux.intel.com>, Len Brown <lenb@...nel.org>, Prarit
 Bhargava <prarit@...hat.com>, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] intel_idle: introduce 'no_native' module parameter

On Tue, 2025-02-18 at 20:57 +0100, Rafael J. Wysocki wrote:
> On Thu, Feb 13, 2025 at 5:07 PM David Arcari <darcari@...hat.com> wrote:
> > 
> > Since commit 18734958e9bf ("intel_idle: Use ACPI _CST for processor models
> > without C-state tables") the intel_idle driver has had the ability to use
> > the ACPI _CST to populate C-states when the processor model is not
> > recognized. However, even when the processor model is recognized (native
> > mode) there are cases where it is useful to make the driver ignore the per
> > cpu idle states in lieu of ACPI C-states (such as specific application
> > performance). Add the 'no_native' module parameter to provide this
> > functionality.
> > 
> > Cc: Jonathan Corbet <corbet@....net>
> > Cc: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> > Cc: Len Brown <lenb@...nel.org>
> > Cc: David Arcari <darcari@...hat.com>
> > Cc: Artem Bityutskiy <dedekind1@...il.com>
> > Cc: Prarit Bhargava <prarit@...hat.com>
> > Cc: linux-doc@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > Signed-off-by: David Arcari <darcari@...hat.com>
> > ---
> > v4: fix !CONFIG_ACPI_PROCESSOR_CSTATE compilation issue
> 
> Artem, have all of your comments been addressed in this version?

Hi, I was away for few days. Yes, this patch looks good to me. Works, and
useful. Granted your comment is also addressed:

Reviewed-by: Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>