linux-kernel - Re: [PATCH] platform/chrome: cros_ec_typec: Add support for setting USB mode via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7fZ1vpb02fn0YoG@google.com>
Date: Fri, 21 Feb 2025 01:41:42 +0000
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: Andrei Kuchynski <akuchynski@...omium.org>
Cc: Prashant Malani <pmalani@...omium.org>,
	Benson Leung <bleung@...omium.org>,
	Abhishek Pandit-Subedi <abhishekpandit@...omium.org>,
	chrome-platform@...ts.linux.dev, Jameson Thies <jthies@...gle.com>,
	Łukasz Bartosik <ukaszb@...omium.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Add support for setting
 USB mode via sysfs

On Thu, Feb 20, 2025 at 01:39:57PM +0000, Andrei Kuchynski wrote:
> On Tue, Feb 18, 2025 at 2:26 PM Tzung-Bi Shih <tzungbi@...nel.org> wrote:
> >
> > On Mon, Feb 10, 2025 at 01:04:19PM +0000, Andrei Kuchynski wrote:
> > > +static int cros_typec_enter_usb_mode(struct typec_port *tc_port, enum usb_mode mode)
> > > +{
> > > +     struct cros_typec_port *port = typec_get_drvdata(tc_port);
> > > +     struct ec_params_typec_control req = {
> > > +             .port = port->port_num,
> > > +             .command = (mode == USB_MODE_USB4) ?
> > > +                     TYPEC_CONTROL_COMMAND_ENTER_MODE : TYPEC_CONTROL_COMMAND_EXIT_MODES,
> > > +             .mode_to_enter = CROS_EC_ALTMODE_USB4
> >
> > The symbol `CROS_EC_ALTMODE_USB4` doesn't exist.  On a related note, wouldn't
> > it always enter CROS_EC_ALTMODE_USB4 if the value is hard-coded here?
> >
> 
> CROS_EC_ALTMODE_USB4 is defined in drivers/platform/chrome/cros_ec_typec.h.

I see.  Overlooked that.