linux-kernel - Re: [PATCH v7 3/6] rust: str: implement `AsRef<BStr>` for `[u8]` and `BStr`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <94DA7409-439D-4D6B-98F5-687A743DB277@collabora.com>
Date: Fri, 21 Feb 2025 13:15:38 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Andreas Hindborg <a.hindborg@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <benno.lossin@...ton.me>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 Masahiro Yamada <masahiroy@...nel.org>,
 Nathan Chancellor <nathan@...nel.org>,
 Nicolas Schier <nicolas@...sle.eu>,
 Luis Chamberlain <mcgrof@...nel.org>,
 rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Adam Bratschi-Kaye <ark.email@...il.com>,
 linux-kbuild@...r.kernel.org,
 Petr Pavlu <petr.pavlu@...e.com>,
 Sami Tolvanen <samitolvanen@...gle.com>,
 Daniel Gomez <da.gomez@...sung.com>,
 Simona Vetter <simona.vetter@...ll.ch>,
 Greg KH <gregkh@...uxfoundation.org>,
 linux-modules@...r.kernel.org
Subject: Re: [PATCH v7 3/6] rust: str: implement `AsRef<BStr>` for `[u8]` and
 `BStr`



> On 21 Feb 2025, at 13:01, Daniel Almeida <daniel.almeida@...labora.com> wrote:
> 
> 
> 
>> On 18 Feb 2025, at 10:00, Andreas Hindborg <a.hindborg@...nel.org> wrote:
>> 
>> Implement `AsRef<BStr>` for `[u8]` and `BStr` so these can be used
>> interchangeably for operations on `BStr`.
>> 
>> Signed-off-by: Andreas Hindborg <a.hindborg@...nel.org>
>> ---
>> rust/kernel/str.rs | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>> 
>> diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs
>> index ba6b1a5c4f99d..c6bd2c69543dc 100644
>> --- a/rust/kernel/str.rs
>> +++ b/rust/kernel/str.rs
>> @@ -125,6 +125,18 @@ fn index(&self, index: Idx) -> &Self::Output {
>>    }
>> }
>> 
>> +impl AsRef<BStr> for [u8] {
>> +    fn as_ref(&self) -> &BStr {
>> +        BStr::from_bytes(self)
>> +    }
>> +}
>> +
>> +impl AsRef<BStr> for BStr {
>> +    fn as_ref(&self) -> &BStr {
>> +        self
>> +    }
>> +}
> 
> Why do you need this last one?

I see that this is used by the following patch.

> 
>> +
>> /// Creates a new [`BStr`] from a string literal.
>> ///
>> /// `b_str!` converts the supplied string literal to byte string, so non-ASCII
>> 
>> -- 
>> 2.47.0

Reviewed-by: Daniel Almeida <daniel.almeida@...labora.com>