linux-kernel - Re: [PATCH v1] io.h: drop unused headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z7ilkKt1waKJuZPi@smile.fi.intel.com>
Date: Fri, 21 Feb 2025 18:10:56 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: kernel test robot <lkp@...el.com>
Cc: Raag Jadav <raag.jadav@...el.com>, arnd@...db.de,
	oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] io.h: drop unused headers

On Fri, Feb 21, 2025 at 11:22:38AM +0800, kernel test robot wrote:
> Hi Raag,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on b16e9f8547a328b19af59afc213ce323124d11e9]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Raag-Jadav/io-h-drop-unused-headers/20250221-013530
> base:   b16e9f8547a328b19af59afc213ce323124d11e9
> patch link:    https://lore.kernel.org/r/20250220173305.2752125-1-raag.jadav%40intel.com
> patch subject: [PATCH v1] io.h: drop unused headers
> config: nios2-randconfig-001-20250221 (https://download.01.org/0day-ci/archive/20250221/202502211137.IRE8qrlR-lkp@intel.com/config)
> compiler: nios2-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250221/202502211137.IRE8qrlR-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202502211137.IRE8qrlR-lkp@intel.com/

...

>    drivers/gpu/drm/drm_draw.c: At top level:
> >> drivers/gpu/drm/drm_draw.c:134:1: warning: data definition has no type or storage class
>      134 | EXPORT_SYMBOL(drm_draw_color_from_xrgb8888);
>          | ^~~~~~~~~~~~~
> >> drivers/gpu/drm/drm_draw.c:134:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
> >> drivers/gpu/drm/drm_draw.c:134:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
>    drivers/gpu/drm/drm_draw.c:151:1: warning: data definition has no type or storage class
>      151 | EXPORT_SYMBOL(drm_draw_blit16);
>          | ^~~~~~~~~~~~~

I haven't looked deeply into this, but it might be the export.h is missing
or it's just a followup of missing bug.h. In any case the io.h patch needs
a prerequisite for dwm_draw.c to eliminate usage of "proxy" headers and follow
IWYU principle. So, it will become a series of two. But as I said before,
let's wait a bit longer.

-- 
With Best Regards,
Andy Shevchenko