linux-kernel - Re: [PATCH v2] arm64: dts: rockchip: add usb typec host support to rk3588-jaguar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c50c6053-4569-44b0-943d-5450960be147@cherry.de>
Date: Fri, 21 Feb 2025 17:43:08 +0100
From: Quentin Schulz <quentin.schulz@...rry.de>
To: Heiko Stuebner <heiko@...ech.de>
Cc: linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Heiko Stuebner <heiko.stuebner@...rry.de>,
 Chen-Yu Tsai <wens@...e.org>
Subject: Re: [PATCH v2] arm64: dts: rockchip: add usb typec host support to
 rk3588-jaguar

Hi Heiko,

On 2/18/25 10:10 PM, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@...rry.de>
> 
> Jaguar has two type-c ports connected to fusb302 controllers that can
> work both in host and device mode and can also run in display-port
> altmode.
> 
> While these ports can work in dual-role data mode, they do not support
> powering the device itself as power-sink. This causes issues because
> the current infrastructure does not cope well with dual-role data
> without dual-role power.
> 
> So add the necessary nodes for the type-c controllers as well
> as enable the relevant core usb nodes, but limit the mode to host-mode
> for now until we figure out device mode.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@...rry.de>

While the USB functionality does work for both ports, and the 
orientation is properly reported, it seems like there may be some issue 
with how the PHY or controller interacts with that info because I do not 
get USB3 speeds when the device is inserted in reverse orientation, 
while I do when it's in normal orientation.

I assume that's the case for the Rock 5 ITX and Orange Pi 5+ as well and 
probably has nothing to do with the DT?

Should we go still go on with trying to merge this patch knowing that? I 
mean USB2 is still better than no USB at all :)

+Cc Chen-Yu, owner of an Orange Pi 5+, who may be able to confirm the 
issue is widespread.

Cheers,
Quentin