linux-kernel - Re: [PATCH] platform/x86: thinkpad_acpi: Add battery quirk for ThinkPad X131e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8a39c1ef-b39b-4c28-b026-26bbb4dbaf7f@aosc.io>
Date: Sat, 22 Feb 2025 00:53:22 +0800
From: Mingcong Bai <jeffbai@...c.io>
To: linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
 ibm-acpi-devel@...ts.sourceforge.net
Cc: Kexy Biscuit <kexybiscuit@...c.io>, Fan Yang <804284660@...com>,
 Xi Ruoyao <xry111@...111.site>, Henrique de Moraes Holschuh
 <hmh@....eng.br>, Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 stable@...r.kernel.org
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: Add battery quirk for
 ThinkPad X131e

Hi all,

在 2025/2/22 00:48, Mingcong Bai 写道:
> Based on the dmesg messages from the original reporter:
> 
> [    4.964073] ACPI: \_SB_.PCI0.LPCB.EC__.HKEY: BCTG evaluated but flagged as error
> [    4.964083] thinkpad_acpi: Error probing battery 2
> 
> Lenovo ThinkPad X131e also needs this battery quirk.
> 
> Reported-by: Fan Yang <804284660@...com>
> Tested-by: Fan Yang <804284660@...com>
> Co-developed-by: Xi Ruoyao <xry111@...111.site>
> Signed-off-by: Xi Ruoyao <xry111@...111.site>
> Signed-off-by: Mingcong Bai <jeffbai@...c.io>
> ---
>   drivers/platform/x86/thinkpad_acpi.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 1fcb0f99695a7..64765c6939a50 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -9960,6 +9960,7 @@ static const struct tpacpi_quirk battery_quirk_table[] __initconst = {
>   	 * Individual addressing is broken on models that expose the
>   	 * primary battery as BAT1.
>   	 */
> +	TPACPI_Q_LNV('G', '8', true),       /* ThinkPad X131e */
>   	TPACPI_Q_LNV('8', 'F', true),       /* Thinkpad X120e */
>   	TPACPI_Q_LNV('J', '7', true),       /* B5400 */
>   	TPACPI_Q_LNV('J', 'I', true),       /* Thinkpad 11e */

I forgot to include a Cc to stable. This issue dates back to as far as 
5.19 (the oldest version available in our distro repository).

Cc: stable@...r.kernel.org

Best Regards,
Mingcong Bai