linux-kernel - Re: [PATCH v1 13/13] ntb: idt: use devm_kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43c873e1-737a-4119-abb7-49cc51acd6a0@intel.com>
Date: Fri, 21 Feb 2025 10:05:09 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Raag Jadav <raag.jadav@...el.com>, perex@...ex.cz, tiwai@...e.com,
 broonie@...nel.org, lgirdwood@...il.com, deller@....de,
 andriy.shevchenko@...ux.intel.com, sre@...nel.org,
 sakari.ailus@...ux.intel.com, mchehab@...nel.org, hverkuil-cisco@...all.nl,
 jdmason@...zu.us, fancer.lancer@...il.com
Cc: linux-sound@...r.kernel.org, linux-fbdev@...r.kernel.org,
 linux-pm@...r.kernel.org, linux-media@...r.kernel.org, ntb@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 13/13] ntb: idt: use devm_kmemdup_array()



On 2/21/25 9:53 AM, Raag Jadav wrote:
> Convert to use devm_kmemdup_array() which is more robust.
> 
> Signed-off-by: Raag Jadav <raag.jadav@...el.com>

I think this patch [1] from earlier today makes this change unnecessary now.

[1]: https://lore.kernel.org/ntb/20250221085748.2298463-1-arnd@kernel.org/

> ---
>  drivers/ntb/hw/idt/ntb_hw_idt.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/ntb/hw/idt/ntb_hw_idt.c b/drivers/ntb/hw/idt/ntb_hw_idt.c
> index 544d8a4d2af5..dbfc53d0ef0c 100644
> --- a/drivers/ntb/hw/idt/ntb_hw_idt.c
> +++ b/drivers/ntb/hw/idt/ntb_hw_idt.c
> @@ -1103,16 +1103,11 @@ static struct idt_mw_cfg *idt_scan_mws(struct idt_ntb_dev *ndev, int port,
>  		}
>  	}
>  
> -	/* Allocate memory for memory window descriptors */
> -	ret_mws = devm_kcalloc(&ndev->ntb.pdev->dev, *mw_cnt, sizeof(*ret_mws),
> -			       GFP_KERNEL);
> -	if (!ret_mws)
> -		return ERR_PTR(-ENOMEM);
> -
>  	/* Copy the info of detected memory windows */
> -	memcpy(ret_mws, mws, (*mw_cnt)*sizeof(*ret_mws));
> +	ret_mws = devm_kmemdup_array(&ndev->ntb.pdev->dev, mws, *mw_cnt,
> +				     sizeof(mws[0]), GFP_KERNEL);
>  
> -	return ret_mws;
> +	return ret_mws ?: ERR_PTR(-ENOMEM);
>  }
>  
>  /*