linux-kernel - Re: [PATCH] io_uring: add missing IORING_MAP_OFF_ZCRX_REGION in io_uring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d510f0c5-d25d-44cb-9974-46026964beca@gmail.com>
Date: Fri, 21 Feb 2025 17:06:14 +0000
From: Pavel Begunkov <asml.silence@...il.com>
To: Jens Axboe <axboe@...nel.dk>, lizetao <lizetao1@...wei.com>,
 Bui Quang Minh <minhquangbui99@...il.com>
Cc: David Wei <dw@...idwei.uk>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "io-uring@...r.kernel.org" <io-uring@...r.kernel.org>
Subject: Re: [PATCH] io_uring: add missing IORING_MAP_OFF_ZCRX_REGION in
 io_uring_mmap

On 2/21/25 16:39, Jens Axboe wrote:
> On 2/21/25 5:20 AM, Pavel Begunkov wrote:
>> On 2/21/25 09:10, lizetao wrote:
>>> Hi,
>>>
>>>> -----Original Message-----
>>>> From: Bui Quang Minh <minhquangbui99@...il.com>
>>>> Sent: Friday, February 21, 2025 5:00 PM
>>>> To: io-uring@...r.kernel.org
>>>> Cc: Jens Axboe <axboe@...nel.dk>; Pavel Begunkov
>>>> <asml.silence@...il.com>; David Wei <dw@...idwei.uk>; linux-
>>>> kernel@...r.kernel.org; Bui Quang Minh <minhquangbui99@...il.com>
>>>> Subject: [PATCH] io_uring: add missing IORING_MAP_OFF_ZCRX_REGION in
>>>> io_uring_mmap
>>>>
>>>> Allow user to mmap the kernel allocated zerocopy-rx refill queue.
>>>>
>>>
>>> Maybe fixed-tag should be added here.
>>
>> No need, it's not strictly a fix, and whlist it's not yet sent to
>> linus, the tags only cause confusion when hashes change, e.g. on rebase.
> 
> I do like using fixes still, if only to provide a link to the original
> commit without needing to dig for it. And yeah there's the occasional
> rebase where I forget to update the sha, but those get discovered pretty
> quick.

Maybe a "Link" tag would be better or some more inconsequential
"Refers-to", but otherwise you can call it a feature and avoid the
hassle of fixing it up, and people getting spammed by tooling,
and Stephen having to write about broken hashes.

-- 
Pavel Begunkov