linux-kernel - [RFC v2 5/5] virtiofs: Disable notifications more aggresively

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250221170626.261687-6-eperezma@redhat.com>
Date: Fri, 21 Feb 2025 18:06:26 +0100
From: Eugenio Pérez <eperezma@...hat.com>
To: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	Stefan Hajnoczi <stefanha@...hat.com>,
	Hanna Reitz <hreitz@...hat.com>,
	linux-kernel@...r.kernel.org,
	German Maglione <gmaglione@...hat.com>,
	virtualization@...ts.linux.dev,
	Stefano Garzarella <sgarzare@...hat.com>,
	yama@...hat.com,
	Vivek Goyal <vgoyal@...hat.com>,
	Miklos Szeredi <miklos@...redi.hu>,
	mst@...hat.com,
	Jason Wang <jasowang@...hat.com>
Subject: [RFC v2 5/5] virtiofs: Disable notifications more aggresively

Disable notifications right before scheduling, instead of waiting until
the work is running.

After applying this patch, fio read test goes from 1191MiB/s to
1263.14Mib/s

Signed-off-by: Eugenio Pérez <eperezma@...hat.com>
---
 fs/fuse/virtio_fs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
index e19c78f2480e..3d6981c0f3c3 100644
--- a/fs/fuse/virtio_fs.c
+++ b/fs/fuse/virtio_fs.c
@@ -915,6 +915,8 @@ static void virtio_fs_vq_done(struct virtqueue *vq)
 
 	dev_dbg(&vq->vdev->dev, "%s %s\n", __func__, fsvq->name);
 
+	/* Shceduled, don't send more notifications */
+	virtqueue_disable_cb(vq);
 	schedule_work(&fsvq->done_work);
 }
 
-- 
2.48.1