linux-kernel - Re: [PATCH V3 2/2] checkpatch: throw error for malformed arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m2wmdjtedt.fsf@Mac.home>
Date: Fri, 21 Feb 2025 17:07:58 +0000
From: Charalampos Mitrodimas <charmitro@...teo.net>
To: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>
Cc: a.hindborg@...nel.org,  alex.gaynor@...il.com,  aliceryhl@...gle.com,
  apw@...onical.com,  arnd@...db.de,  aswinunni01@...il.com,
  axboe@...nel.dk,  benno.lossin@...ton.me,  bhelgaas@...gle.com,
  bjorn3_gh@...tonmail.com,  boqun.feng@...il.com,  dakr@...nel.org,
  dwaipayanray1@...il.com,  ethan.twardy@...il.com,
  fujita.tomonori@...il.com,  gary@...yguo.net,
  gregkh@...uxfoundation.org,  joe@...ches.com,
  linux-kernel@...r.kernel.org,  lukas.bulwahn@...il.com,
  ojeda@...nel.org,  pbonzini@...hat.com,  rust-for-linux@...r.kernel.org,
  tmgross@...ch.edu,  walmeida@...rosoft.com
Subject: Re: [PATCH V3 2/2] checkpatch: throw error for malformed arrays

Guilherme Giacomo Simoes <trintaeoitogc@...il.com> writes:

> Charalampos Mitrodimas <charmitro@...teo.net> wrote:
>> Hi Guilherme,
>> 
>> Will this work now that the field is called "authors" and not "author"?
>> I think you forgot to update the regex here.
> I don't know, I make change in modules and samples, and I forget runing again
> the checkpatch.
> Sorry .. 
> I will send a v4 

Keep in mind that now we also have the faux device sample upstream,
which uses the old single-author module field. Please build against the
latest tree and include the fix for that driver.

It can be found under the path "samples/rust/rust_driver_faux.rs".

>
>> What do you think about this instead?
>> "Prefer each array element on a separate line$herevet"
> For me, looks like great
>
> Thanks,
> Guilherme