linux-kernel - Re: [PATCH] docs: trace: decode_msr.py: make it compatible with python 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z7i9hY7347X4P6bq@duo.ucw.cz>
Date: Fri, 21 Feb 2025 18:53:09 +0100
From: Pavel Machek <pavel@....cz>
To: Jonathan Corbet <corbet@....net>
Cc: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
	Linux Doc Mailing List <linux-doc@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] docs: trace: decode_msr.py: make it compatible with
 python 3

On Thu 2025-02-13 09:46:42, Jonathan Corbet wrote:
> Mauro Carvalho Chehab <mchehab+huawei@...nel.org> writes:
> 
> > This script uses print <foo> instead of print(foo), which is
> > incompatible with Python 3.
> >
> > Fix it.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> > ---
> >  Documentation/trace/postprocess/decode_msr.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/trace/postprocess/decode_msr.py b/Documentation/trace/postprocess/decode_msr.py
> > index aa9cc7abd5c2..f5609b16f589 100644
> > --- a/Documentation/trace/postprocess/decode_msr.py
> > +++ b/Documentation/trace/postprocess/decode_msr.py
> > @@ -32,6 +32,6 @@ for j in sys.stdin:
> >  					break
> >  		if r:
> >  			j = j.replace(" " + m.group(2), " " + r + "(" + m.group(2) + ")")
> > -	print j,
> > +	print(j)
> 
> This does make me wonder when this script was last used ... it hasn't
> seen a real change since it was added in 2015.  Oh well, it should at
> least work with current Python ... applied, thanks.

This conversion is wrong, AFACIT. Old code one avoids adding \n, new
adds it.

BR,
								Pavel

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)