linux-kernel - Re: [PATCH v5] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174015998416.3469778.7696460950092748736.robh@kernel.org>
Date: Fri, 21 Feb 2025 12:11:04 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Macpaul Lin <macpaul.lin@...iatek.com>
Cc: Simon Sun <simon.sun@...jingtech.com>, linux-kernel@...r.kernel.org, 
 linux-usb@...r.kernel.org, devicetree@...r.kernel.org, 
 Project_Global_Chrome_Upstream_Group@...iatek.com, 
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
 Alexandre Mergnat <amergnat@...libre.com>, Macpaul Lin <macpaul@...il.com>, 
 Conor Dooley <conor+dt@...nel.org>, Bear Wang <bear.wang@...iatek.com>, 
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, 
 Yow-Shin Liou <yow-shin.liou@...iatek.com>, 
 Fabien Parent <fparent@...libre.com>, 
 Chris-qj chen <chris-qj.chen@...iatek.com>, 
 Matthias Brugger <matthias.bgg@...il.com>, 
 Pablo Sun <pablo.sun@...iatek.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: Re: [PATCH v5] arm64: dts: mediatek: mt8395-genio-1200-evk: add
 support for TCPC port


On Fri, 21 Feb 2025 22:49:41 +0800, Macpaul Lin wrote:
> From: Fabien Parent <fparent@...libre.com>
> 
> Enable USB Type-C support on MediaTek MT8395 Genio 1200 EVK by adding
> configuration for TCPC Port, USB-C connector, MUX IT5205 and related
> settings.
> 
> Configure dual role switch capability, set up PD (Power Delivery) profiles,
> and establish endpoints for SS (SuperSpeed) and HS (HighSpeed) USB.
> 
> Update pinctrl configurations for U3 P0 VBus default pins and set dr_mode
> to "otg" for OTG (On-The-Go) mode operation.
> 
> Add ITE IT5205 (TYPEC MUX) under I2C2 bus and configure its properties;
> also add references and configurations to 'typec-mux' node.
> 
> Signed-off-by: Fabien Parent <fparent@...libre.com>
> Signed-off-by: Yow-Shin Liou <yow-shin.liou@...iatek.com>
> Signed-off-by: Simon Sun <simon.sun@...jingtech.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
> ---
>  .../dts/mediatek/mt8395-genio-1200-evk.dts    | 100 ++++++++++++++++++
>  1 file changed, 100 insertions(+)
> 
> Changes for v2:
>  - Drop the no need '1/2' DT Schema update patch in the 1st version.
>  - Fix indent for 'ports' node, it should under the 'connector' node.
>  - Correct the index for 'port@0' and 'port@1' node.
> 
> Changes for v3:
>  - Correct the order between new added nodes.
> 
> Changes for v4:
>  - Reorder for property 'op-sink-microwatt'.
>  - Fix indentation for 'source-pdos' and 'sink-pdos' nodes.
>  - Correct node 'pin-cmd-dat' with 'pins-vbus'.
>  - Add both Highspeed and Superspeed ports to ssusb0 port.
>  - Set 'role-switch-default-mode' = "peripheral" for ssusb0 port.
>  - Rename endpoint of USB data port to 'mtu3_hs0_role_sw' and
>    'mtu3_ss0_role_sw'.
>  - Drop it5205fn phandle for node typec-mux@48.
>  - Reorder properties of typec-mux@48
>  - Add "Reviewed-by:" tag. Thanks!
> 
> Changes for v5:
>  - Squash two patches into one patch and refine commit messages:
>    suggested by reviewer.
>  - Drop 'role-switch-default-mode'
>  - Add altmodes settings
>  - Drop 'Reviewed-by:' tag since the two sub patches has been combined
>    into a new patch.
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/mediatek/' for 20250221144941.2844333-1-macpaul.lin@...iatek.com:

arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dtb: usb@...01000: 'ports' does not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/usb/mediatek,mtu3.yaml#