linux-kernel - Re: [PATCH] wifi: cfg80211: convert timeouts to secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2e55eb5b-9df3-48e2-8e93-511249672b05@oss.qualcomm.com>
Date: Fri, 21 Feb 2025 10:31:59 -0800
From: Jeff Johnson <jeff.johnson@....qualcomm.com>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>,
        Johannes Berg <johannes@...solutions.net>,
        "open list:802.11 (including CFG80211/NL80211)"
 <linux-wireless@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wifi: cfg80211: convert timeouts to secs_to_jiffies()

On 2/19/2025 12:32 PM, Easwar Hariharan wrote:
> Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced
> secs_to_jiffies().  As the value here is a multiple of 1000, use
> secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication.
> 
> This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
> the following Coccinelle rules:
> 
> @depends on patch@
> expression E;
> @@
> 
> -msecs_to_jiffies(E * 1000)
> +secs_to_jiffies(E)
> 
> -msecs_to_jiffies(E * MSEC_PER_SEC)
> +secs_to_jiffies(E)
> 
> Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
> ---
>  net/wireless/scan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/wireless/scan.c b/net/wireless/scan.c
> index cd2124329521..1de25e9763cb 100644
> --- a/net/wireless/scan.c
> +++ b/net/wireless/scan.c
> @@ -1365,7 +1365,7 @@ void cfg80211_bss_age(struct cfg80211_registered_device *rdev,
>                        unsigned long age_secs)
>  {
>  	struct cfg80211_internal_bss *bss;
> -	unsigned long age_jiffies = msecs_to_jiffies(age_secs * MSEC_PER_SEC);
> +	unsigned long age_jiffies = secs_to_jiffies(age_secs);
>  
>  	spin_lock_bh(&rdev->bss_lock);
>  	list_for_each_entry(bss, &rdev->bss_list, list)

Reviewed-by: Jeff Johnson <jeff.johnson@....qualcomm.com>