linux-kernel - Re: [PATCH *-next 00/18] Remove weird and needless 'return' for void APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250221110042.2ec3c276@hermes.local>
Date: Fri, 21 Feb 2025 11:00:42 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Zijun Hu <quic_zijuhu@...cinc.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Will Deacon
 <will@...nel.org>, "Aneesh Kumar K.V" <aneesh.kumar@...nel.org>, Andrew
 Morton <akpm@...ux-foundation.org>, Nick Piggin <npiggin@...il.com>, Peter
 Zijlstra <peterz@...radead.org>, Arnd Bergmann <arnd@...db.de>, Thomas
 Gleixner <tglx@...utronix.de>, Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>, "Rafael J. Wysocki"
 <rafael@...nel.org>, "Danilo Krummrich" <dakr@...nel.org>, Eric Dumazet
 <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Johannes Berg
 <johannes@...solutions.net>, "Jamal Hadi Salim" <jhs@...atatu.com>, Cong
 Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, Jason
 Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>, Linus Walleij
 <linus.walleij@...aro.org>, "Bartosz Golaszewski" <brgl@...ev.pl>, Lee
 Jones <lee@...nel.org>, Thomas Graf <tgraf@...g.ch>, Christoph Hellwig
 <hch@....de>, Marek Szyprowski <m.szyprowski@...sung.com>, Robin Murphy
 <robin.murphy@....com>, "Miquel Raynal" <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
 Zijun Hu <zijun_hu@...oud.com>, <linux-arch@...r.kernel.org>,
 <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
 <linux-crypto@...r.kernel.org>, <netdev@...r.kernel.org>,
 <linux-wireless@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
 <linux-gpio@...r.kernel.org>, <linux-pm@...r.kernel.org>,
 <iommu@...ts.linux.dev>, <linux-mtd@...ts.infradead.org>
Subject: Re: [PATCH *-next 00/18] Remove weird and needless 'return' for
 void APIs

On Fri, 21 Feb 2025 05:02:05 -0800
Zijun Hu <quic_zijuhu@...cinc.com> wrote:

> This patch series is to remove weird and needless 'return' for
> void APIs under include/ with the following pattern:
> 
> api_header.h:
> 
> void api_func_a(...);
> 
> static inline void api_func_b(...)
> {
> 	return api_func_a(...);
> }
> 
> Remove the needless 'return' in api_func_b().
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> ---
> Zijun Hu (18):
>       mm/mmu_gather: Remove needless return in void API tlb_remove_page()
>       cpu: Remove needless return in void API suspend_enable_secondary_cpus()
>       crypto: api - Remove needless return in void API crypto_free_tfm()
>       crypto: scomp - Remove needless return in void API crypto_scomp_free_ctx()
>       sysfs: Remove needless return in void API sysfs_enable_ns()
>       skbuff: Remove needless return in void API consume_skb()
>       wifi: mac80211: Remove needless return in void API _ieee80211_hw_set()
>       net: sched: Remove needless return in void API qdisc_watchdog_schedule_ns()
>       ipv4/igmp: Remove needless return in void API ip_mc_dec_group()
>       IB/rdmavt: Remove needless return in void API rvt_mod_retry_timer()
>       ratelimit: Remove needless return in void API ratelimit_default_init()
>       siox: Remove needless return in void API siox_driver_unregister()
>       gpiolib: Remove needless return in two void APIs
>       PM: wakeup: Remove needless return in three void APIs
>       mfd: db8500-prcmu: Remove needless return in three void APIs
>       rhashtable: Remove needless return in three void APIs
>       dma-mapping: Remove needless return in five void APIs
>       mtd: nand: Do not return void function in void function
> 
>  include/asm-generic/tlb.h           |  2 +-
>  include/crypto/internal/scompress.h |  2 +-
>  include/linux/cpu.h                 |  2 +-
>  include/linux/crypto.h              |  2 +-
>  include/linux/dma-mapping.h         | 12 ++++++------
>  include/linux/gpio.h                |  4 ++--
>  include/linux/igmp.h                |  2 +-
>  include/linux/mfd/dbx500-prcmu.h    |  6 +++---
>  include/linux/mtd/nand.h            | 18 ++++++++++++------
>  include/linux/pm_wakeup.h           |  6 +++---
>  include/linux/ratelimit.h           |  4 ++--
>  include/linux/rhashtable.h          |  6 +++---
>  include/linux/siox.h                |  2 +-
>  include/linux/skbuff.h              |  2 +-
>  include/linux/sysfs.h               |  2 +-
>  include/net/mac80211.h              |  2 +-
>  include/net/pkt_sched.h             |  2 +-
>  include/rdma/rdmavt_qp.h            |  2 +-
>  18 files changed, 42 insertions(+), 36 deletions(-)
> ---
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> change-id: 20250221-rmv_return-f1dc82d492f0
> 
> Best regards,

Is this something that could be done with a coccinelle script?